[PATCH] drm/bochs: switch fb_ops over to use drm_fb_helper_cfb helpers

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Newsgroups	linux.kernel
Subject	[PATCH] drm/bochs: switch fb_ops over to use drm_fb_helper_cfb helpers
Date	Mon, 03 Jul 2017 00:00:01 +0200
Message-ID	<tYV4l-88R-7@gated-at.bofh.it> (permalink)
X-Original-To	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kraxel@redhat.com
X-Mailer	git-send-email 1.7.10.4
X-Sa-Exim-Connect-IP	86.191.132.89
X-Sa-Exim-Mail-From	mark.cave-ayland@ilande.co.uk
X-Sa-Exim-Version	4.2.1 (built Sun, 08 Jan 2012 02:45:44 +0000)
X-Sa-Exim-Scanned	Yes (on s16892447.onlinehome-server.info)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	33
Organization	linux.* mail to news gateway
X-Original-Date	Sun, 2 Jul 2017 22:52:43 +0100
X-Original-Message-ID	<1499032363-8290-1-git-send-email-mark.cave-ayland@ilande.co.uk>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1679569

Show key headers only | View raw

The current drm_fb_helper_sys helpers referenced in fb_ops assume that the
video memory is in system RAM. This is not the case for sparc which uses direct
physical memory accesses for IO memory and causes the bochs_drm module to panic
immediately upon startup as it tries to initialise the framebuffer.

Switching fb_ops over to use the drm_fb_helper_cfb helpers ensures that the
correct accesses are used on sparc, fixing the panic and allowing the
bochs_drm module to function under qemu-system-sparc64.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
 drivers/gpu/drm/bochs/bochs_fbdev.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/bochs/bochs_fbdev.c b/drivers/gpu/drm/bochs/bochs_fbdev.c
index 932a769..d3a75c2 100644
--- a/drivers/gpu/drm/bochs/bochs_fbdev.c
+++ b/drivers/gpu/drm/bochs/bochs_fbdev.c
@@ -23,9 +23,9 @@ static int bochsfb_mmap(struct fb_info *info,
 static struct fb_ops bochsfb_ops = {
 	.owner = THIS_MODULE,
 	DRM_FB_HELPER_DEFAULT_OPS,
-	.fb_fillrect = drm_fb_helper_sys_fillrect,
-	.fb_copyarea = drm_fb_helper_sys_copyarea,
-	.fb_imageblit = drm_fb_helper_sys_imageblit,
+	.fb_fillrect = drm_fb_helper_cfb_fillrect,
+	.fb_copyarea = drm_fb_helper_cfb_copyarea,
+	.fb_imageblit = drm_fb_helper_cfb_imageblit,
 	.fb_mmap = bochsfb_mmap,
 };
 
-- 
1.7.10.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] drm/bochs: switch fb_ops over to use drm_fb_helper_cfb helpers Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> - 2017-07-03 00:00 +0200
  Re: [PATCH] drm/bochs: switch fb_ops over to use drm_fb_helper_cfb  helpers Daniel Vetter <daniel@ffwll.ch> - 2017-07-03 10:20 +0200
    Re: [PATCH] drm/bochs: switch fb_ops over to use drm_fb_helper_cfb  helpers Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> - 2017-07-03 10:40 +0200
      Re: [PATCH] drm/bochs: switch fb_ops over to use drm_fb_helper_cfb  helpers Gerd Hoffmann <kraxel@redhat.com> - 2017-07-03 11:00 +0200
        Re: [PATCH] drm/bochs: switch fb_ops over to use drm_fb_helper_cfb  helpers Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> - 2017-07-03 11:10 +0200

csiph-web