Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1678423

Re: [PATCH v4 2/2] fs/dcache.c: fix spin lockup issue on nlru->lock

Show all headers | View raw

On 6/30/2017 4:18 AM, Andrew Morton wrote:
>
>> --- a/fs/dcache.c
>> +++ b/fs/dcache.c
>> @@ -1133,11 +1133,12 @@ void shrink_dcache_sb(struct super_block *sb)
>>   		LIST_HEAD(dispose);
>>   
>>   		freed = list_lru_walk(&sb->s_dentry_lru,
>> -			dentry_lru_isolate_shrink, &dispose, UINT_MAX);
>> +			dentry_lru_isolate_shrink, &dispose, 1024);
>>   
>>   		this_cpu_sub(nr_dentry_unused, freed);
>>   		shrink_dentry_list(&dispose);
>> -	} while (freed > 0);
>> +		cond_resched();
>> +	} while (list_lru_count(&sb->s_dentry_lru) > 0);
>>   }
>>   EXPORT_SYMBOL(shrink_dcache_sb);
> I'll add a cc:stable to this one - a large dentry list is a relatively
> common thing.
>
> I'm assumng that [1/2] does not need to be backported, OK?

I think we should include [1/2] as well along with this patch, as this patch
is using list_lru_count(), which can return incorrect count if [1/2] is 
not included.

Also, all the previous patches submitted for fixing this issue must be 
dropped i.e,
mm/list_lru.c: use cond_resched_lock() for nlru->lock must be dropped.

-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] mm/list_lru.c: use cond_resched_lock() for nlru->lock Sahitya Tummala <stummala@codeaurora.org> - 2017-06-20 05:00 +0200
  [PATCH v2] fs/dcache.c: fix spin lockup issue on nlru->lock Sahitya Tummala <stummala@codeaurora.org> - 2017-06-21 08:40 +0200
    Re: [PATCH v2] fs/dcache.c: fix spin lockup issue on nlru->lock Vladimir Davydov <vdavydov.dev@gmail.com> - 2017-06-21 18:40 +0200
      Re: [PATCH v2] fs/dcache.c: fix spin lockup issue on nlru->lock Sahitya Tummala <stummala@codeaurora.org> - 2017-06-22 18:40 +0200
        Re: [PATCH v2] fs/dcache.c: fix spin lockup issue on nlru->lock Vladimir Davydov <vdavydov.dev@gmail.com> - 2017-06-22 19:50 +0200
          [PATCH v3 1/2] mm/list_lru.c: fix list_lru_count_node() to be race free Sahitya Tummala <stummala@codeaurora.org> - 2017-06-28 08:10 +0200
            [PATCH v3 2/2] fs/dcache.c: fix spin lockup issue on nlru->lock Sahitya Tummala <stummala@codeaurora.org> - 2017-06-28 08:10 +0200
            Re: [PATCH v3 1/2] mm/list_lru.c: fix list_lru_count_node() to be  race free Vladimir Davydov <vdavydov.dev@gmail.com> - 2017-06-28 20:00 +0200
              [PATCH v4 1/2] mm/list_lru.c: fix list_lru_count_node() to be race free Sahitya Tummala <stummala@codeaurora.org> - 2017-06-29 05:40 +0200
                Re: [PATCH v4 1/2] mm/list_lru.c: fix list_lru_count_node() to be  race free Vladimir Davydov <vdavydov.dev@gmail.com> - 2017-07-01 18:30 +0200
              [PATCH v4 2/2] fs/dcache.c: fix spin lockup issue on nlru->lock Sahitya Tummala <stummala@codeaurora.org> - 2017-06-29 05:50 +0200
                Re: [PATCH v4 2/2] fs/dcache.c: fix spin lockup issue on nlru->lock Andrew Morton <akpm@linux-foundation.org> - 2017-06-30 00:50 +0200
                Re: [PATCH v4 2/2] fs/dcache.c: fix spin lockup issue on nlru->lock Sahitya Tummala <stummala@codeaurora.org> - 2017-06-30 05:20 +0200
                Re: [PATCH v4 2/2] fs/dcache.c: fix spin lockup issue on nlru->lock Vladimir Davydov <vdavydov.dev@gmail.com> - 2017-07-01 18:30 +0200

csiph-web