Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1677823

Re: [PATCH] staging: lustre: lnet: remove dead code

Show all headers | View raw

On Wed, Jun 28, 2017 at 09:42:36PM -0700, Dmitriy Cherkasov wrote:
> Remove code which was permanently disabled with ifdefs.
> 
> This also resolves the following checkpatch warning which was
> triggered by the dead code:
> 
> WARNING: space prohibited before semicolon
> 
> Signed-off-by: Dmitriy Cherkasov <dmitriy@oss-tech.org>
> ---
>  drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h
> index 5540de6..7c487fa 100644
> --- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h
> +++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h
> @@ -521,13 +521,7 @@ struct ksock_proto {
>  
>  static inline __u32 ksocknal_csum(__u32 crc, unsigned char const *p, size_t len)
>  {
> -#if 1
>  	return crc32_le(crc, p, len);

Even better yet, why not just replace the callers of this tiny function,
with crc32_le() instead and delete this useless wrapper?

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: lustre: lnet: remove dead code Dmitriy Cherkasov <dmitriy@oss-tech.org> - 2017-06-29 07:00 +0200
  Re: [PATCH] staging: lustre: lnet: remove dead code Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-29 16:40 +0200
  Re: [PATCH v2] staging: lustre: lnet: remove dead code and  crc32_le() wrapper Joe Perches <joe@perches.com> - 2017-06-30 05:40 +0200
    Re: [PATCH v2] staging: lustre: lnet: remove dead code and crc32_le()  wrapper Dmitriy Cherkasov <dmitriy@oss-tech.org> - 2017-06-30 06:00 +0200
  [PATCH v2] staging: lustre: lnet: remove dead code and crc32_le() wrapper Dmitriy Cherkasov <dmitriy@oss-tech.org> - 2017-06-30 05:40 +0200
    [PATCH v3] staging: lustre: lnet: remove dead code and crc32_le() wrapper Dmitriy Cherkasov <dmitriy@oss-tech.org> - 2017-06-30 06:10 +0200
      [PATCH v4] staging: lustre: lnet: remove dead code and crc32_le() wrapper Dmitriy Cherkasov <dmitriy@oss-tech.org> - 2017-06-30 08:00 +0200
      Re: [PATCH v3] staging: lustre: lnet: remove dead code and  crc32_le() wrapper Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-30 08:10 +0200

csiph-web