Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1678435

Re: [PATCH v2] staging: lustre: lnet: remove dead code and crc32_le() wrapper

Show all headers | View raw

On Fri, 2017-06-30 at 03:29 +0000, Dmitriy Cherkasov wrote:
> After removing code which was premanently disabled with ifdefs, the
> function ksocknal_csum() becomes just a wrapper for crc32_le(). Remove
> this useless wrapper and instead call crc32_le() directly.
> 
> This also resolves the following checkpatch warning which was
> triggered by the dead code:
> 
> WARNING: space prohibited before semicolon

Please use checkpatch on your proposed patches before
sending them.

> diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c
[]
> @@ -201,7 +201,7 @@
>  			if (fragnob > sum)
>  				fragnob = sum;
>  
> -			conn->ksnc_rx_csum = ksocknal_csum(conn->ksnc_rx_csum,
> +			conn->ksnc_rx_csum = crc32_le(conn->ksnc_rx_csum,
>  							   iov[i].iov_base,
>  							   fragnob);

Please realign the subsequent lines to the open parenthesis.

>  		}
> @@ -243,7 +243,7 @@
>  			if (fragnob > sum)
>  				fragnob = sum;
>  
> -			conn->ksnc_rx_csum = ksocknal_csum(conn->ksnc_rx_csum,
> +			conn->ksnc_rx_csum = crc32_le(conn->ksnc_rx_csum,
>  							   base, fragnob);

etc...

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: lustre: lnet: remove dead code Dmitriy Cherkasov <dmitriy@oss-tech.org> - 2017-06-29 07:00 +0200
  Re: [PATCH] staging: lustre: lnet: remove dead code Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-29 16:40 +0200
  Re: [PATCH v2] staging: lustre: lnet: remove dead code and  crc32_le() wrapper Joe Perches <joe@perches.com> - 2017-06-30 05:40 +0200
    Re: [PATCH v2] staging: lustre: lnet: remove dead code and crc32_le()  wrapper Dmitriy Cherkasov <dmitriy@oss-tech.org> - 2017-06-30 06:00 +0200
  [PATCH v2] staging: lustre: lnet: remove dead code and crc32_le() wrapper Dmitriy Cherkasov <dmitriy@oss-tech.org> - 2017-06-30 05:40 +0200
    [PATCH v3] staging: lustre: lnet: remove dead code and crc32_le() wrapper Dmitriy Cherkasov <dmitriy@oss-tech.org> - 2017-06-30 06:10 +0200
      [PATCH v4] staging: lustre: lnet: remove dead code and crc32_le() wrapper Dmitriy Cherkasov <dmitriy@oss-tech.org> - 2017-06-30 08:00 +0200
      Re: [PATCH v3] staging: lustre: lnet: remove dead code and  crc32_le() wrapper Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-30 08:10 +0200

csiph-web