Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1674801

Re: [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to rtnl_link_ops.slave_changelink

From Matthias Schiffer <mschiffer@universe-factory.net>
Newsgroups linux.kernel
Subject Re: [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to rtnl_link_ops.slave_changelink
Date 2017-06-26 15:50 +0200
Message-ID <tWCyT-30W-27@gated-at.bofh.it> (permalink)
References (1 earlier) <tWnJx-1Zo-37@gated-at.bofh.it> <tWtvz-5SD-9@gated-at.bofh.it> <tWtvz-5SD-7@gated-at.bofh.it> <tWxSy-8w1-13@gated-at.bofh.it> <tWCpb-2Xw-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On 06/26/2017 03:33 PM, David Ahern wrote:
> On 6/26/17 2:43 AM, Matthias Schiffer wrote:
>> On 06/26/2017 06:08 AM, David Ahern wrote:
>>> On 6/25/17 10:04 PM, David Ahern wrote:
>>>> On 6/25/17 3:56 PM, Matthias Schiffer wrote:
>>>>> Add support for extended error reporting.
>>>>>
>>>>> Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
>>>>> ---
>>>>
>>>>
>>>> Acked-by: David Ahern <dsahern@gmail.com>
>>>>
>>>
>>> Actually, you are missing the chagne to br_port_slave_changelink.
>>>
>>
>> I'm confused. I am changing br_port_slave_changelink? All my patches are
>> compile-tested.
>>
> 
> You are changing the signature of slave_changelink, no?
> 
> net/bridge/br_netlink.c:
>         .slave_changelink       = br_port_slave_changelink,
> 


Please read my patch again, I *am* changing br_port_slave_changelink to
match the new signature (this is the net/bridge/br_netlink.c change
appearing in the diffstat).

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH net-next v2 0/5] net: add netlink_ext_ack support to rtnl_link_ops Matthias Schiffer <mschiffer@universe-factory.net> - 2017-06-26 00:00 +0200
  [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to rtnl_link_ops.slave_changelink Matthias Schiffer <mschiffer@universe-factory.net> - 2017-06-26 00:00 +0200
    Re: [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to  rtnl_link_ops.slave_changelink David Ahern <dsahern@gmail.com> - 2017-06-26 06:10 +0200
      Re: [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to  rtnl_link_ops.slave_changelink Matthias Schiffer <mschiffer@universe-factory.net> - 2017-06-26 10:50 +0200
        Re: [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to  rtnl_link_ops.slave_changelink David Ahern <dsahern@gmail.com> - 2017-06-26 15:40 +0200
          Re: [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to  rtnl_link_ops.slave_changelink David Ahern <dsahern@gmail.com> - 2017-06-26 15:50 +0200
          Re: [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to  rtnl_link_ops.slave_changelink Matthias Schiffer <mschiffer@universe-factory.net> - 2017-06-26 15:50 +0200
    Re: [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to  rtnl_link_ops.slave_changelink David Ahern <dsahern@gmail.com> - 2017-06-26 06:10 +0200
  [PATCH net-next v2 1/5] net: add netlink_ext_ack argument to rtnl_link_ops.newlink Matthias Schiffer <mschiffer@universe-factory.net> - 2017-06-26 00:00 +0200
    Re: [PATCH net-next v2 1/5] net: add netlink_ext_ack argument to  rtnl_link_ops.newlink David Ahern <dsahern@gmail.com> - 2017-06-26 06:10 +0200
  [PATCH net-next v2 2/5] net: add netlink_ext_ack argument to rtnl_link_ops.changelink Matthias Schiffer <mschiffer@universe-factory.net> - 2017-06-26 00:00 +0200
    Re: [PATCH net-next v2 2/5] net: add netlink_ext_ack argument to  rtnl_link_ops.changelink David Ahern <dsahern@gmail.com> - 2017-06-26 06:10 +0200
  Re: [PATCH net-next v2 0/5] net: add netlink_ext_ack support to  rtnl_link_ops David Miller <davem@davemloft.net> - 2017-06-27 05:20 +0200

csiph-web