Re: [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to rtnl_link_ops.slave_changelink

Path	csiph.com!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Matthias Schiffer <mschiffer@universe-factory.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to rtnl_link_ops.slave_changelink
Date	Mon, 26 Jun 2017 15:50:03 +0200
Message-ID	<tWCyT-30W-27@gated-at.bofh.it> (permalink)
References	<tWnJw-1Zo-11@gated-at.bofh.it> <tWnJx-1Zo-37@gated-at.bofh.it> <tWtvz-5SD-9@gated-at.bofh.it> <tWtvz-5SD-7@gated-at.bofh.it> <tWxSy-8w1-13@gated-at.bofh.it> <tWCpb-2Xw-1@gated-at.bofh.it>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0
MIME-Version	1.0
Content-Type	multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GTa8fbVwFBKQGGC8RgHH4pbDJVT0tmtkl"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	93
Organization	linux.* mail to news gateway
X-Original-Cc	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-can@vger.kernel.org, linux-ppp@vger.kernel.org, linux-wpan@vger.kernel.org
X-Original-Date	Mon, 26 Jun 2017 15:45:31 +0200
X-Original-Message-ID	<bb1892a4-2227-cdc4-e017-f39f133fd20a@universe-factory.net>
X-Original-References	<cover.1498425679.git.mschiffer@universe-factory.net> <498ff06f59d5ce13b2ad3e1c1902c3d348ca3c00.1498425679.git.mschiffer@universe-factory.net> <b097a69e-4449-b124-c39e-4dbdbae7c218@gmail.com> <dd3f596b-4519-398c-a2ec-afdaf5f2f058@gmail.com> <15d2138d-5026-a35b-8a3c-2a88d05df688@universe-factory.net> <27b8d607-7442-0a42-1389-9548840445dc@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1674801

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

On 06/26/2017 03:33 PM, David Ahern wrote:
> On 6/26/17 2:43 AM, Matthias Schiffer wrote:
>> On 06/26/2017 06:08 AM, David Ahern wrote:
>>> On 6/25/17 10:04 PM, David Ahern wrote:
>>>> On 6/25/17 3:56 PM, Matthias Schiffer wrote:
>>>>> Add support for extended error reporting.
>>>>>
>>>>> Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
>>>>> ---
>>>>
>>>>
>>>> Acked-by: David Ahern <dsahern@gmail.com>
>>>>
>>>
>>> Actually, you are missing the chagne to br_port_slave_changelink.
>>>
>>
>> I'm confused. I am changing br_port_slave_changelink? All my patches are
>> compile-tested.
>>
> 
> You are changing the signature of slave_changelink, no?
> 
> net/bridge/br_netlink.c:
>         .slave_changelink       = br_port_slave_changelink,
> 


Please read my patch again, I *am* changing br_port_slave_changelink to
match the new signature (this is the net/bridge/br_netlink.c change
appearing in the diffstat).

Thread

[PATCH net-next v2 0/5] net: add netlink_ext_ack support to rtnl_link_ops Matthias Schiffer <mschiffer@universe-factory.net> - 2017-06-26 00:00 +0200
  [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to rtnl_link_ops.slave_changelink Matthias Schiffer <mschiffer@universe-factory.net> - 2017-06-26 00:00 +0200
    Re: [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to  rtnl_link_ops.slave_changelink David Ahern <dsahern@gmail.com> - 2017-06-26 06:10 +0200
      Re: [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to  rtnl_link_ops.slave_changelink Matthias Schiffer <mschiffer@universe-factory.net> - 2017-06-26 10:50 +0200
        Re: [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to  rtnl_link_ops.slave_changelink David Ahern <dsahern@gmail.com> - 2017-06-26 15:40 +0200
          Re: [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to  rtnl_link_ops.slave_changelink David Ahern <dsahern@gmail.com> - 2017-06-26 15:50 +0200
          Re: [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to  rtnl_link_ops.slave_changelink Matthias Schiffer <mschiffer@universe-factory.net> - 2017-06-26 15:50 +0200
    Re: [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to  rtnl_link_ops.slave_changelink David Ahern <dsahern@gmail.com> - 2017-06-26 06:10 +0200
  [PATCH net-next v2 1/5] net: add netlink_ext_ack argument to rtnl_link_ops.newlink Matthias Schiffer <mschiffer@universe-factory.net> - 2017-06-26 00:00 +0200
    Re: [PATCH net-next v2 1/5] net: add netlink_ext_ack argument to  rtnl_link_ops.newlink David Ahern <dsahern@gmail.com> - 2017-06-26 06:10 +0200
  [PATCH net-next v2 2/5] net: add netlink_ext_ack argument to rtnl_link_ops.changelink Matthias Schiffer <mschiffer@universe-factory.net> - 2017-06-26 00:00 +0200
    Re: [PATCH net-next v2 2/5] net: add netlink_ext_ack argument to  rtnl_link_ops.changelink David Ahern <dsahern@gmail.com> - 2017-06-26 06:10 +0200
  Re: [PATCH net-next v2 0/5] net: add netlink_ext_ack support to  rtnl_link_ops David Miller <davem@davemloft.net> - 2017-06-27 05:20 +0200

csiph-web