Re: [PATCH 3/3] fsi/master-gpio: Add external mode

From	Joel Stanley <joel@jms.id.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] fsi/master-gpio: Add external mode
Date	2017-06-21 08:10 +0200
Message-ID	<tUGZY-2ml-7@gated-at.bofh.it> (permalink)
References	<tU1ap-ON-5@gated-at.bofh.it> <tU1aq-ON-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Jeremy,

On Mon, Jun 19, 2017 at 6:56 PM, Jeremy Kerr <jk@ozlabs.org> wrote:
> This change introduces an 'external mode' for GPIO-based FSI masters,
> +static ssize_t external_mode_show(struct device *dev,
> +               struct device_attribute *attr, char *buf)
> +{
> +       struct fsi_master_gpio *master = dev_get_drvdata(dev);
> +
> +       return snprintf(buf, PAGE_SIZE - 1, "%u",

I gave this a spin on a machine today and noticed we're missing a
newline there. Should this be "%u\n"?

Cheers,

Joel

> +                       master->external_mode ? 1 : 0);
> +}
> +

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 3/3] fsi/master-gpio: Add external mode Joel Stanley <joel@jms.id.au> - 2017-06-21 08:10 +0200
  Re: [PATCH 3/3] fsi/master-gpio: Add external mode Jeremy Kerr <jk@ozlabs.org> - 2017-06-22 00:10 +0200

csiph-web