Re: [PATCH v3] PCI: dwc: dra7xx: Fix compilation warning.

From	Arvind Yadav <arvind.yadav.cs@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] PCI: dwc: dra7xx: Fix compilation warning.
Date	2017-06-19 11:40 +0200
Message-ID	<tU1k5-S2-1@gated-at.bofh.it> (permalink)
References	<tSyNc-fM-9@gated-at.bofh.it> <tSK1X-7lg-5@gated-at.bofh.it> <tSUE1-5WD-13@gated-at.bofh.it> <tU1aq-ON-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

Thanks for you suggestion. I will update change log and re-submit.

Regards
~arvind

On Monday 19 June 2017 02:49 PM, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Friday 16 June 2017 01:48 PM, Arvind Yadav wrote:
>> Hi Kishon/Bjorn,
>>
>> What is correct Setting for these two PCIECTRL_DRA7XX_CONF_IRQSTATUS_MSI and
>> PCIECTRL_DRA7XX_CONF_IRQSTATUS_MAIN register.
>>
>> Value of register After change:
>>   register[PCIECTRL_DRA7XX_CONF_IRQSTATUS_MSI] = LEG_EP_INTERRUPTS |  MSI
>>                                            = 0x1f
>> register[PCIECTRL_DRA7XX_CONF_IRQSTATUS_MAIN] =  INTERRUPTS
>>                    =  0x1fff
>> Is this correct?
> That's correct. That patch as such is correct but the changelog and subject has
> to be fixed. You can use something like below for subject and changelog.
>
> "PCI: dwc: dra7xx: Fix incorrect usage of IRQSTATUS_* registers
>
> commit 47ff3de911 ("PCI: dra7xx: Add TI DRA7xx PCIe driver") in order to clear
> MSI and MAIN interrupts requests wrote '0' to PCIECTRL_TI_CONF_IRQSTATUS_MSI
> and PCIECTRL_TI_CONF_IRQSTATUS_MAIN registers. However the TRM has mentioned to
> write '1' to clear pending event in these two registers. Fix it here.
>
> This also helps to get rid of the following compilation warning:
> drivers/pci/dwc/pci-dra7xx.c: In function ‘dra7xx_pcie_enable_msi_interrupts’:
> drivers/pci/dwc/pci-dra7xx.c:177:7: warning: large integer implicitly truncated
> to unsigned type [-Woverflow]
>         ~LEG_EP_INTERRUPTS & ~MSI);
>         ^
> drivers/pci/dwc/pci-dra7xx.c: In function ‘dra7xx_pcie_enable_wrapper_interrupts’:
> drivers/pci/dwc/pci-dra7xx.c:187:7: warning: large integer implicitly truncated
> to unsigned type [-Woverflow]
>         ~INTERRUPTS);"
>
> For the patch itself
> Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
>
> Thanks
> Kishon

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3] PCI: dwc: dra7xx: Fix compilation warning. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-06-15 11:00 +0200
  Re: [PATCH v3] PCI: dwc: dra7xx: Fix compilation warning. Bjorn Helgaas <helgaas@kernel.org> - 2017-06-15 23:00 +0200
    Re: [PATCH v3] PCI: dwc: dra7xx: Fix compilation warning. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-06-16 10:20 +0200
      Re: [PATCH v3] PCI: dwc: dra7xx: Fix compilation warning. Kishon Vijay Abraham I <kishon@ti.com> - 2017-06-19 11:30 +0200
        Re: [PATCH v3] PCI: dwc: dra7xx: Fix compilation warning. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-06-19 11:40 +0200

csiph-web