Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1666581
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v3] PCI: dwc: dra7xx: Fix compilation warning. |
| Date | 2017-06-15 11:00 +0200 |
| Message-ID | <tSyNc-fM-9@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
drivers/pci/dwc/pci-dra7xx.c: In function ‘dra7xx_pcie_enable_msi_interrupts’:
drivers/pci/dwc/pci-dra7xx.c:177:7: warning: large integer implicitly truncated to unsigned type [-Woverflow]
~LEG_EP_INTERRUPTS & ~MSI);
^
drivers/pci/dwc/pci-dra7xx.c: In function ‘dra7xx_pcie_enable_wrapper_interrupts’:
drivers/pci/dwc/pci-dra7xx.c:187:7: warning: large integer implicitly truncated to unsigned type [-Woverflow]
~INTERRUPTS);
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
Changes in v2:
Add casts in the definitions.
Changes in v3:
Change logic insted of casting.
drivers/pci/dwc/pci-dra7xx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
index 8decf46..668dc15 100644
--- a/drivers/pci/dwc/pci-dra7xx.c
+++ b/drivers/pci/dwc/pci-dra7xx.c
@@ -174,7 +174,7 @@ static int dra7xx_pcie_establish_link(struct dw_pcie *pci)
static void dra7xx_pcie_enable_msi_interrupts(struct dra7xx_pcie *dra7xx)
{
dra7xx_pcie_writel(dra7xx, PCIECTRL_DRA7XX_CONF_IRQSTATUS_MSI,
- ~LEG_EP_INTERRUPTS & ~MSI);
+ LEG_EP_INTERRUPTS | MSI);
dra7xx_pcie_writel(dra7xx,
PCIECTRL_DRA7XX_CONF_IRQENABLE_SET_MSI,
@@ -184,7 +184,7 @@ static void dra7xx_pcie_enable_msi_interrupts(struct dra7xx_pcie *dra7xx)
static void dra7xx_pcie_enable_wrapper_interrupts(struct dra7xx_pcie *dra7xx)
{
dra7xx_pcie_writel(dra7xx, PCIECTRL_DRA7XX_CONF_IRQSTATUS_MAIN,
- ~INTERRUPTS);
+ INTERRUPTS);
dra7xx_pcie_writel(dra7xx, PCIECTRL_DRA7XX_CONF_IRQENABLE_SET_MAIN,
INTERRUPTS);
}
--
1.9.1
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH v3] PCI: dwc: dra7xx: Fix compilation warning. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-06-15 11:00 +0200
Re: [PATCH v3] PCI: dwc: dra7xx: Fix compilation warning. Bjorn Helgaas <helgaas@kernel.org> - 2017-06-15 23:00 +0200
Re: [PATCH v3] PCI: dwc: dra7xx: Fix compilation warning. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-06-16 10:20 +0200
Re: [PATCH v3] PCI: dwc: dra7xx: Fix compilation warning. Kishon Vijay Abraham I <kishon@ti.com> - 2017-06-19 11:30 +0200
Re: [PATCH v3] PCI: dwc: dra7xx: Fix compilation warning. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-06-19 11:40 +0200
csiph-web