Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1664816

Re: [PATCH 1/7] staging: rtl8723bs: wifi_regd.c: put spaces around binary operators

Show all headers | View raw

On Mon, Jun 12, 2017 at 12:46:10PM +0200, Fabian Wolff wrote:
> This patch adds spaces around the binary operators '-' and '+', which
> is the preferred style, and reformats a pointer argument declaration
> to fix a false positive "spaces preferred around that '*'" message
> reported by checkpatch.pl.
> 
> Signed-off-by: Fabian Wolff <fabian.wolff@fau.de>
> Signed-off-by: Mate Horvath <horvatmate@gmail.com>
> ---
>  drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/wifi_regd.c b/drivers/staging/rtl8723bs/os_dep/wifi_regd.c
> index 9c61125..803eab0 100644
> --- a/drivers/staging/rtl8723bs/os_dep/wifi_regd.c
> +++ b/drivers/staging/rtl8723bs/os_dep/wifi_regd.c
> @@ -20,7 +20,7 @@
>  
>  /* 2G chan 01 - chan 11 */
>  #define RTW_2GHZ_CH01_11	\
> -	REG_RULE(2412-10, 2462+10, 40, 0, 20, 0)
> +	REG_RULE(2412 - 10, 2462 + 10, 40, 0, 20, 0)
>  
>  /*
>   *We enable active scan on these a case
> @@ -29,12 +29,12 @@
>  
>  /* 2G chan 12 - chan 13, PASSIV SCAN */
>  #define RTW_2GHZ_CH12_13	\
> -	REG_RULE(2467-10, 2472+10, 40, 0, 20,	\
> +	REG_RULE(2467 - 10, 2472 + 10, 40, 0, 20,	\
>  	NL80211_RRF_PASSIVE_SCAN)
>  
>  /* 2G chan 14, PASSIVS SCAN, NO OFDM (B only) */
>  #define RTW_2GHZ_CH14	\
> -	REG_RULE(2484-10, 2484+10, 40, 0, 20,	\
> +	REG_RULE(2484 - 10, 2484 + 10, 40, 0, 20,	\
>  	NL80211_RRF_PASSIVE_SCAN | NL80211_RRF_NO_OFDM)
>  
>  static const struct ieee80211_regdomain rtw_regdom_rd = {
> @@ -116,8 +116,8 @@ static int _rtw_reg_notifier_apply(struct wiphy *wiphy,
>  }
>  
>  static const struct ieee80211_regdomain *_rtw_regdomain_select(struct
> -							       rtw_regulatory
> -							       *reg)
> +							       rtw_regulatory *
> +							       reg)

Why make this last change?  It's not an arithmatic one :(

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/7] staging: rtl8723bs: wifi_regd.c: put spaces around binary operators Fabian Wolff <fabian.wolff@fau.de> - 2017-06-12 13:00 +0200
  Re: [PATCH 1/7] staging: rtl8723bs: wifi_regd.c: put spaces around  binary operators Greg KH <gregkh@linuxfoundation.org> - 2017-06-13 15:00 +0200
    Re: [PATCH 1/7] staging: rtl8723bs: wifi_regd.c: put spaces around  binary operators Greg KH <gregkh@linuxfoundation.org> - 2017-06-13 15:20 +0200
      [PATCH v2 1/5] staging: rtl8723bs: wifi_regd.c: put spaces around binary operators Fabian Wolff <fabian.wolff@fau.de> - 2017-06-13 23:10 +0200
      [PATCH v2 4/5] staging: rtl8723bs: wifi_regd.c: adjust alignment to match open parenthesis Fabian Wolff <fabian.wolff@fau.de> - 2017-06-13 23:10 +0200
      [PATCH v2 5/5] staging: rtl8723bs: wifi_regd.c: insert blank line after declarations Fabian Wolff <fabian.wolff@fau.de> - 2017-06-13 23:10 +0200
      [PATCH v2 2/5] staging: rtl8723bs: wifi_regd.c: fix comment formatting Fabian Wolff <fabian.wolff@fau.de> - 2017-06-13 23:10 +0200
      [PATCH v2 3/5] staging: rtl8723bs: wifi_regd.c: remove superfluous spaces from pointer arguments Fabian Wolff <fabian.wolff@fau.de> - 2017-06-13 23:10 +0200
      [PATCH v2 0/5] staging: rtl8723bs: wifi_regd.c: fix checkpatch errors and warnings Fabian Wolff <fabian.wolff@fau.de> - 2017-06-13 23:10 +0200
  Re: [PATCH 1/7] staging: rtl8723bs: wifi_regd.c: put spaces around  binary operators Ian W MORRISON <ianwmorrison@gmail.com> - 2017-06-13 15:40 +0200
    Re: [PATCH 1/7] staging: rtl8723bs: wifi_regd.c: put spaces around  binary operators Dan Carpenter <dan.carpenter@oracle.com> - 2017-06-13 16:40 +0200
      Re: [PATCH 1/7] staging: rtl8723bs: wifi_regd.c: put spaces around  binary operators Ian W MORRISON <ianwmorrison@gmail.com> - 2017-06-14 13:50 +0200
        Re: [PATCH 1/7] staging: rtl8723bs: wifi_regd.c: put spaces around  binary operators Dan Carpenter <dan.carpenter@oracle.com> - 2017-06-14 14:20 +0200
          Re: [PATCH 1/7] staging: rtl8723bs: wifi_regd.c: put spaces around  binary operators Joe Perches <joe@perches.com> - 2017-06-14 15:30 +0200

csiph-web