Re: [PATCH 1/7] staging: rtl8723bs: wifi_regd.c: put spaces around binary operators

From	Ian W MORRISON <ianwmorrison@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/7] staging: rtl8723bs: wifi_regd.c: put spaces around binary operators
Date	2017-06-14 13:50 +0200
Message-ID	<tSeY9-4EV-1@gated-at.bofh.it> (permalink)
References	<tRveF-13J-5@gated-at.bofh.it> <tRveF-13J-3@gated-at.bofh.it> <tRUd3-6S-1@gated-at.bofh.it> <tRV98-Fy-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 14 June 2017 at 00:36, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> Kernel style is to have spaces around the operators.  This is staging
> code so we do all the style fixes.  We don't always update older drivers
> but sometimes we do.  No one is planning to change those drivers though
> so I guess the answer is no we're not going to update those unless you
> are?
>

Thanks for the explanation. I assume submitting changes for the
drivers I identified would only be seen as minor corrections to 'the
chaff' resulting in unnecessary churn. If however it is expected that
corrections should be made when identified then I'm willing to prepare
a patch set. I'm happy to take advice either way.

Thread

[PATCH 1/7] staging: rtl8723bs: wifi_regd.c: put spaces around binary operators Fabian Wolff <fabian.wolff@fau.de> - 2017-06-12 13:00 +0200
  Re: [PATCH 1/7] staging: rtl8723bs: wifi_regd.c: put spaces around  binary operators Greg KH <gregkh@linuxfoundation.org> - 2017-06-13 15:00 +0200
    Re: [PATCH 1/7] staging: rtl8723bs: wifi_regd.c: put spaces around  binary operators Greg KH <gregkh@linuxfoundation.org> - 2017-06-13 15:20 +0200
      [PATCH v2 1/5] staging: rtl8723bs: wifi_regd.c: put spaces around binary operators Fabian Wolff <fabian.wolff@fau.de> - 2017-06-13 23:10 +0200
      [PATCH v2 4/5] staging: rtl8723bs: wifi_regd.c: adjust alignment to match open parenthesis Fabian Wolff <fabian.wolff@fau.de> - 2017-06-13 23:10 +0200
      [PATCH v2 5/5] staging: rtl8723bs: wifi_regd.c: insert blank line after declarations Fabian Wolff <fabian.wolff@fau.de> - 2017-06-13 23:10 +0200
      [PATCH v2 2/5] staging: rtl8723bs: wifi_regd.c: fix comment formatting Fabian Wolff <fabian.wolff@fau.de> - 2017-06-13 23:10 +0200
      [PATCH v2 3/5] staging: rtl8723bs: wifi_regd.c: remove superfluous spaces from pointer arguments Fabian Wolff <fabian.wolff@fau.de> - 2017-06-13 23:10 +0200
      [PATCH v2 0/5] staging: rtl8723bs: wifi_regd.c: fix checkpatch errors and warnings Fabian Wolff <fabian.wolff@fau.de> - 2017-06-13 23:10 +0200
  Re: [PATCH 1/7] staging: rtl8723bs: wifi_regd.c: put spaces around  binary operators Ian W MORRISON <ianwmorrison@gmail.com> - 2017-06-13 15:40 +0200
    Re: [PATCH 1/7] staging: rtl8723bs: wifi_regd.c: put spaces around  binary operators Dan Carpenter <dan.carpenter@oracle.com> - 2017-06-13 16:40 +0200
      Re: [PATCH 1/7] staging: rtl8723bs: wifi_regd.c: put spaces around  binary operators Ian W MORRISON <ianwmorrison@gmail.com> - 2017-06-14 13:50 +0200
        Re: [PATCH 1/7] staging: rtl8723bs: wifi_regd.c: put spaces around  binary operators Dan Carpenter <dan.carpenter@oracle.com> - 2017-06-14 14:20 +0200
          Re: [PATCH 1/7] staging: rtl8723bs: wifi_regd.c: put spaces around  binary operators Joe Perches <joe@perches.com> - 2017-06-14 15:30 +0200

csiph-web