Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1664723
| From | Enric Balletbo Serra <eballetbo@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: brcmfmac: Fix kernel oops on resume when request firmware fails. |
| Date | 2017-06-13 12:30 +0200 |
| Message-ID | <tRRfc-6Mo-35@gated-at.bofh.it> (permalink) |
| References | <tKmpP-6Mp-1@gated-at.bofh.it> <tRN1V-41I-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hello Kalle, 2017-06-13 7:54 GMT+02:00 Kalle Valo <kvalo@codeaurora.org>: > Enric Balletbo i Serra <enric.balletbo@collabora.com> wrote: > >> When request firmware fails, brcmf_ops_sdio_remove is being called and >> brcmf_bus freed. In such circumstancies if you do a suspend/resume cycle >> the kernel hangs on resume due a NULL pointer dereference in resume >> function. >> >> Steps to reproduce the problem: >> - modprobe brcmfmac without the firmware >> brcmfmac mmc1:0001:1: Direct firmware load for brcm/brcmfmac4354-sdio.bin >> failed with error -2 >> - do a suspend/resume cycle (echo mem > /sys/power/state) >> >> Protect against the NULL pointer derefence by checking if dev_get_drvdata >> returned a valid pointer. >> >> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > > My understanding is that there's a new version of this patch which fixes > the issue. If not, let me know. > > Patch set to Superseded. > Yes there are these patch series [1] that fixes the issue, I guess Arend is working on a v2 to fix a small issue we found. [1] https://www.spinics.net/lists/linux-wireless/msg162762.html > -- > https://patchwork.kernel.org/patch/9743159/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches > Regards, Enric
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: brcmfmac: Fix kernel oops on resume when request firmware fails. Kalle Valo <kvalo@codeaurora.org> - 2017-06-13 08:00 +0200
Re: brcmfmac: Fix kernel oops on resume when request firmware fails. Enric Balletbo Serra <eballetbo@gmail.com> - 2017-06-13 12:30 +0200
Re: brcmfmac: Fix kernel oops on resume when request firmware fails. Arend van Spriel <arend.vanspriel@broadcom.com> - 2017-06-13 13:00 +0200
csiph-web