Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1664723
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Enric Balletbo Serra <eballetbo@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | Re: brcmfmac: Fix kernel oops on resume when request firmware fails. |
| Date | Tue, 13 Jun 2017 12:30:02 +0200 |
| Message-ID | <tRRfc-6Mo-35@gated-at.bofh.it> (permalink) |
| References | <tKmpP-6Mp-1@gated-at.bofh.it> <tRN1V-41I-17@gated-at.bofh.it> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Yl/eNCRVjA3Wvkkc44w3/3yIsWADx0G/3fhNQUdbQXk=; b=ii/d2kpUnSEZ5HUGOL9vG1GSYGO6Smy4Subx9gskDps+Pqmi1Gubtk1beqbh0Wm1qK 8qXoGJTIQfVV5Bn3e6Rayva39sQ6vz5LyyH6icAb+ilp6FseKkAIN6ffekadoZESpTQV qnAyvb2Ca3hGmabgcADp0nfA9WqT3HGyeKoTCIN0H3O+MotewwameCVnTvOoJ8LpcxO+ GzDGrM3b4wEuwrCCPw5/JCGbwHeaZd4lceYRjWminzhEcXuBHcg9F/OD3uabyYh8pMBM 57L87g3ev/ygTDleIS8gH91Pt1XpNBOrSXRNOo2f0v9prdhgfb0dnHUlKzKi5l9JVIc/ 7N8Q== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Yl/eNCRVjA3Wvkkc44w3/3yIsWADx0G/3fhNQUdbQXk=; b=Nt/cGHAT4hUz+5hrHwh2uivvwZkPx9TNgY19LDR3MkWL9/lQEJbj8E48Pzg6V9ml9n 9ypTimvL8+AGQ0D9jpFyjF8GlRGZpOAZ6t4wBGWZc1xYFcCTEFEHkJ4raBtho0kK6duZ ZrKT5h8rq7/mVUyBX4qsXbjLVjPh3PFNUs8maH5WXo1dVw1C3vXe9PIYMqYNFuZAHuPn XRX2TKMexRrI+Guj/1ZSdtmvizr78xtyPuNB+kDWQHOCG01XN/C2CNtgQ4Hr0yyK/1va YJwPfLctZzj9rWv1qQ7zN+/kPgpNTNuamfv7Qvyprg+8UnblB2LRTnE0cixMDg3rQp+y YueA== |
| X-Gm-Message-State | AKS2vOz4wxV7rylv63eBEIVLNJtscBPaa8pdhMajJQ4rjmxkfaEJZOiS fA8Onesp+yAaOkxe04XbdLQIUqA5qw== |
| X-Received | by 10.107.10.230 with SMTP id 99mr4287916iok.11.1497349415486; Tue, 13 Jun 2017 03:23:35 -0700 (PDT) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset="UTF-8" |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 40 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Enric Balletbo i Serra <enric.balletbo@collabora.com>, Arend van Spriel <arend.vanspriel@broadcom.com>, "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>, brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org, linux-kernel <linux-kernel@vger.kernel.org>, Hante Meuleman <hante.meuleman@broadcom.com>, Christian Daudt <csd@broadcom.com> |
| X-Original-Date | Tue, 13 Jun 2017 12:23:35 +0200 |
| X-Original-Message-ID | <CAFqH_53v341QhUewFR5aQdZE1bPo5J5TY0G6zkXU9y0c5VEz1g@mail.gmail.com> |
| X-Original-References | <20170523180733.26276-1-enric.balletbo@collabora.com> <20170613055448.C0CD36075B@smtp.codeaurora.org> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1664723 |
Show key headers only | View raw
Hello Kalle, 2017-06-13 7:54 GMT+02:00 Kalle Valo <kvalo@codeaurora.org>: > Enric Balletbo i Serra <enric.balletbo@collabora.com> wrote: > >> When request firmware fails, brcmf_ops_sdio_remove is being called and >> brcmf_bus freed. In such circumstancies if you do a suspend/resume cycle >> the kernel hangs on resume due a NULL pointer dereference in resume >> function. >> >> Steps to reproduce the problem: >> - modprobe brcmfmac without the firmware >> brcmfmac mmc1:0001:1: Direct firmware load for brcm/brcmfmac4354-sdio.bin >> failed with error -2 >> - do a suspend/resume cycle (echo mem > /sys/power/state) >> >> Protect against the NULL pointer derefence by checking if dev_get_drvdata >> returned a valid pointer. >> >> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > > My understanding is that there's a new version of this patch which fixes > the issue. If not, let me know. > > Patch set to Superseded. > Yes there are these patch series [1] that fixes the issue, I guess Arend is working on a v2 to fix a small issue we found. [1] https://www.spinics.net/lists/linux-wireless/msg162762.html > -- > https://patchwork.kernel.org/patch/9743159/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches > Regards, Enric
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: brcmfmac: Fix kernel oops on resume when request firmware fails. Kalle Valo <kvalo@codeaurora.org> - 2017-06-13 08:00 +0200
Re: brcmfmac: Fix kernel oops on resume when request firmware fails. Enric Balletbo Serra <eballetbo@gmail.com> - 2017-06-13 12:30 +0200
Re: brcmfmac: Fix kernel oops on resume when request firmware fails. Arend van Spriel <arend.vanspriel@broadcom.com> - 2017-06-13 13:00 +0200
csiph-web