Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1664169

Re: [PATCH 03/11] kernfs: add an API to get kernfs node from inode number

From Tejun Heo <tj@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 03/11] kernfs: add an API to get kernfs node from inode number
Date 2017-06-12 20:40 +0200
Message-ID <tRCpQ-5OW-9@gated-at.bofh.it> (permalink)
References <tO2LT-6Ey-3@gated-at.bofh.it> <tO2LT-6Ey-23@gated-at.bofh.it> <tRCg9-5LZ-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Ooh, one more thing.

On Mon, Jun 12, 2017 at 02:20:28PM -0400, Tejun Heo wrote:
> > +struct kernfs_node *kernfs_get_node_by_ino(struct kernfs_root *root,
> > +					   unsigned int ino)

Can we name this kernfs_find_and_get_by_ino() for consistency?  And
the RCU optimization does seem prominent compared to other find/get
functions which all just use kernfs_mutex (still not objecting).

Thanks.

-- 
tejun

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

Re: [PATCH 03/11] kernfs: add an API to get kernfs node from inode  number Tejun Heo <tj@kernel.org> - 2017-06-12 20:30 +0200
  Re: [PATCH 03/11] kernfs: add an API to get kernfs node from inode  number Tejun Heo <tj@kernel.org> - 2017-06-12 20:40 +0200

csiph-web