Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1664169

Re: [PATCH 03/11] kernfs: add an API to get kernfs node from inode number

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Tejun Heo <tj@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 03/11] kernfs: add an API to get kernfs node from inode number
Date Mon, 12 Jun 2017 20:40:02 +0200
Message-ID <tRCpQ-5OW-9@gated-at.bofh.it> (permalink)
References <tO2LT-6Ey-3@gated-at.bofh.it> <tO2LT-6Ey-23@gated-at.bofh.it> <tRCg9-5LZ-1@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1j7/UmdvGUF73WtPs9rsLR3qCoh0j/oz05hrVyNEkeM=; b=Qa8QGgeqMly6AXe6LMTOfWA6YtJEMhjEko5+Ko6/6v34syoeqM1yvRKkn9zQ3mEFl7 LjtlOVUed4TjWZUHAZFavPADXHi+WxxRkrHTRfSNTLmtDc0g+mKTdzRgkRP/L1z40zTv prNe8KkI6eMpWbSX1A8irYTzSMxvOGNx/FLpKVoyiq/IPVpQLCOeNKLn+P+hUydI/kWm kQPLjSfp3YJ2IdrGiUfkpyVRlqkLqhz28HHix/4xFdE7G01uRN5T07tuzIWAYH4M6p9e FgZ1e5229J/tv0yM5f4yMCZnkKxBhcgoZNEf7db/skipel18j74sXDPt3FddbnlS6GsE MR6w==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=1j7/UmdvGUF73WtPs9rsLR3qCoh0j/oz05hrVyNEkeM=; b=fJu0SU+UYqdXkAc6J9b8RaAqBZmX1DBG9JK/Qjb5RavsLk/lavE6bBAIdlYwR9yE1z 3hbAJzjhbuBfdITXeHUk71xAd4KdJXeNp00iEX3f3Sme0XrEnZN10XhOR9z0uIGtCG7f wioMcUivSwHw4V4cYDRMO4LKPoAhlJy9r5OLNeA3OuU77GNMTurwJ66sYudMVkbzcF4A G4JxJly/KsGxnAKdT+OiGV3Pf639P31uDs89ksdAtomwG6TzvoxDB5WB3oazakFa2EGU Kc761REb1zXy542h71+g/i/ydrgk1lo1+9x/Pce5LsGzMkyWPkKODlTcraxsQgk09Slb ygpQ==
X-Gm-Message-State AKS2vOyd07lBtHIB950MNDbx6rbOEU0sLvNFOduMH1x3LSCyHaE3MY+4 sCOJBUjdaMHBUG8hOqw=
X-Received by 10.13.210.66 with SMTP id u63mr234004ywd.285.1497292654904; Mon, 12 Jun 2017 11:37:34 -0700 (PDT)
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent Mutt/1.8.2 (2017-04-18)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 14
Organization linux.* mail to news gateway
X-Original-Cc linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, gregkh@linuxfoundation.org, hch@lst.de, axboe@fb.com, rostedt@goodmis.org, lizefan@huawei.com, Kernel-team@fb.com, Shaohua Li <shli@fb.com>
X-Original-Date Mon, 12 Jun 2017 14:37:33 -0400
X-Original-Message-ID <20170612183733.GJ19206@htj.duckdns.org>
X-Original-References <cover.1496432591.git.shli@fb.com> <41d336f7006d63c6dd5bddf407c16de8064debc3.1496432591.git.shli@fb.com> <20170612182028.GH19206@htj.duckdns.org>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1664169

Show key headers only | View raw


Ooh, one more thing.

On Mon, Jun 12, 2017 at 02:20:28PM -0400, Tejun Heo wrote:
> > +struct kernfs_node *kernfs_get_node_by_ino(struct kernfs_root *root,
> > +					   unsigned int ino)

Can we name this kernfs_find_and_get_by_ino() for consistency?  And
the RCU optimization does seem prominent compared to other find/get
functions which all just use kernfs_mutex (still not objecting).

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

Re: [PATCH 03/11] kernfs: add an API to get kernfs node from inode  number Tejun Heo <tj@kernel.org> - 2017-06-12 20:30 +0200
  Re: [PATCH 03/11] kernfs: add an API to get kernfs node from inode  number Tejun Heo <tj@kernel.org> - 2017-06-12 20:40 +0200

csiph-web