Re: [PATCH 1/2] arch: Define CPU_BIG_ENDIAN for all fixed big endian archs

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] arch: Define CPU_BIG_ENDIAN for all fixed big endian archs
Date	2017-06-09 18:50 +0200
Message-ID	<tQvgL-3VG-45@gated-at.bofh.it> (permalink)
References	<tQdWy-1BJ-19@gated-at.bofh.it> <tQdWy-1BJ-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Babu Moger <babu.moger@oracle.com>
Date: Thu,  8 Jun 2017 15:17:22 -0700

> While working on enabling queued rwlock on SPARC, found
> this following code in include/asm-generic/qrwlock.h
> which uses CONFIG_CPU_BIG_ENDIAN to clear a byte.
> 
> static inline u8 *__qrwlock_write_byte(struct qrwlock *lock)
>  {
> 	return (u8 *)lock + 3 * IS_BUILTIN(CONFIG_CPU_BIG_ENDIAN);
>  }
> 
> Problem is many of the fixed big endian architectures dont define
> CPU_BIG_ENDIAN and clears the wrong byte.
> 
> Define CPU_BIG_ENDIAN for all the fixed big endian architecture.
> 
> Here is the orinal discussion
> http://www.spinics.net/lists/devicetree/msg178101.html
> 
> Signed-off-by: Babu Moger <babu.moger@oracle.com>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: David S. Miller <davem@davemloft.net>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] arch: Define CPU_BIG_ENDIAN for all fixed big endian archs Babu Moger <babu.moger@oracle.com> - 2017-06-09 00:20 +0200
  Re: [PATCH 1/2] arch: Define CPU_BIG_ENDIAN for all fixed big endian archs Geert Uytterhoeven <geert@linux-m68k.org> - 2017-06-09 09:10 +0200
    Re: [PATCH 1/2] arch: Define CPU_BIG_ENDIAN for all fixed big endian  archs Babu Moger <babu.moger@oracle.com> - 2017-06-09 18:00 +0200
  Re: [PATCH 1/2] arch: Define CPU_BIG_ENDIAN for all fixed big  endian archs David Miller <davem@davemloft.net> - 2017-06-09 18:50 +0200

csiph-web