Re: [PATCH 1/2] arch: Define CPU_BIG_ENDIAN for all fixed big endian archs

From	Babu Moger <babu.moger@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] arch: Define CPU_BIG_ENDIAN for all fixed big endian archs
Date	2017-06-09 18:00 +0200
Message-ID	<tQuum-3qu-11@gated-at.bofh.it> (permalink)
References	<tQdWy-1BJ-19@gated-at.bofh.it> <tQdWy-1BJ-17@gated-at.bofh.it> <tQmds-6TG-3@gated-at.bofh.it>
Organization	Oracle Corporation

Show all headers | View raw

On 6/9/2017 2:03 AM, Geert Uytterhoeven wrote:
> On Fri, Jun 9, 2017 at 12:17 AM, Babu Moger <babu.moger@oracle.com> wrote:
>> While working on enabling queued rwlock on SPARC, found
>> this following code in include/asm-generic/qrwlock.h
>> which uses CONFIG_CPU_BIG_ENDIAN to clear a byte.
>>
>> static inline u8 *__qrwlock_write_byte(struct qrwlock *lock)
>>   {
>>          return (u8 *)lock + 3 * IS_BUILTIN(CONFIG_CPU_BIG_ENDIAN);
>>   }
>>
>> Problem is many of the fixed big endian architectures dont define
>> CPU_BIG_ENDIAN and clears the wrong byte.
>>
>> Define CPU_BIG_ENDIAN for all the fixed big endian architecture.
>>
>> Here is the orinal discussion
>> http://www.spinics.net/lists/devicetree/msg178101.html
>>
>> Signed-off-by: Babu Moger <babu.moger@oracle.com>
>> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Hmm, the link above refers to a mail from me? ;-)
>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

One more question before I resubmit.

Dave,
I have added CONFIG_CPU_BIG_ENDIAN for sparc via my earlier patch.
https://patchwork.ozlabs.org/patch/766735/
Should I exclude sparc here?
Thanks
Babu

>
> Gr{oetje,eeting}s,
>
>                          Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                  -- Linus Torvalds

Thread

[PATCH 1/2] arch: Define CPU_BIG_ENDIAN for all fixed big endian archs Babu Moger <babu.moger@oracle.com> - 2017-06-09 00:20 +0200
  Re: [PATCH 1/2] arch: Define CPU_BIG_ENDIAN for all fixed big endian archs Geert Uytterhoeven <geert@linux-m68k.org> - 2017-06-09 09:10 +0200
    Re: [PATCH 1/2] arch: Define CPU_BIG_ENDIAN for all fixed big endian  archs Babu Moger <babu.moger@oracle.com> - 2017-06-09 18:00 +0200
  Re: [PATCH 1/2] arch: Define CPU_BIG_ENDIAN for all fixed big  endian archs David Miller <davem@davemloft.net> - 2017-06-09 18:50 +0200

csiph-web