Groups > linux.kernel > #1662055

Some filesystems set MNT_* flags in superblock->s_flags

From	David Howells <dhowells@redhat.com>
Newsgroups	linux.kernel
Subject	Some filesystems set MNT_* flags in superblock->s_flags
Date	2017-06-09 09:50 +0200
Message-ID	<tQmQb-78W-49@gated-at.bofh.it> (permalink)
References	<tMRpv-GU-9@gated-at.bofh.it> <tJXUu-7yP-3@gated-at.bofh.it> <tMRpv-GU-9@gated-at.bofh.it>
Organization	Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw

Al Viro <viro@ZenIV.linux.org.uk> wrote:

> 	* what the hell is ms_flags thing doing in __vfs_new_sb_config()?
> It's a really vile mix of unrelated flags and operations we had in existing
> mount(2) ABI.  With MS_KERNMOUNT thrown into that loo^Wmix.  Sure, we need
> to parse the garbage fed to mount(2).  And we need to pass that garbage to
> "legacy" types as well, but let's not inflict it upon the new mechanisms.

Hmmm...  Some ->remount_fs() operations attempt to alter the MS_* flags that
correspond to MNT_* flags.  Coda, for example:

	static int coda_remount(struct super_block *sb, int *flags, char *data)
	{
		sync_filesystem(sb);
		*flags |= MS_NOATIME;
		return 0;
	}

But this is quashed in do_remount_sb:

	sb->s_flags = (sb->s_flags & ~MS_RMT_MASK) | (flags & MS_RMT_MASK);

And others set them directly in s_flags, v9fs_fill_super() for example sets
MS_NOATIME:

	sb->s_flags |= MS_ACTIVE | MS_DIRSYNC | MS_NOATIME;

I'm guessing things like this should be got rid of, but does there need to be
a way to inform mount() that these should be set on the vfsmount?

David

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Some filesystems set MNT_* flags in superblock->s_flags David Howells <dhowells@redhat.com> - 2017-06-09 09:50 +0200
  Re: Some filesystems set MNT_* flags in superblock->s_flags Miklos Szeredi <mszeredi@redhat.com> - 2017-06-09 10:10 +0200

csiph-web