[PATCH] ARM: OMAP: PM: stop early on systems without twl

From	Sebastian Reichel <sre@kernel.org>
Newsgroups	linux.kernel
Subject	[PATCH] ARM: OMAP: PM: stop early on systems without twl
Date	2017-06-10 00:40 +0200
Message-ID	<tQAJs-7ia-27@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Motorola Droid 4 has an OMAP4, but no TWL6030. It currently
complains verbosely about this during boot:

twl: not initialized
twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1375000 Vs max 1316660
twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1375000 Vs max 1316660
twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1375000 Vs max 1316660
twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1375000 Vs max 1316660
twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1375000 Vs max 1316660
twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1375000 Vs max 1316660
twl6030_uv_to_vsel:OUT OF RANGE! non mapped vsel for 1410000 Vs max 1316660
omap2_set_init_voltage: unable to find boot up OPP for vdd_core
omap2_set_init_voltage: unable to set vdd_core
omap2_set_init_voltage: unable to find boot up OPP for vdd_iva
omap2_set_init_voltage: unable to set vdd_iva

While proper support for CPCAP should be added at some point,
let's exit early in omap2_common_pm_late_init() until that
has been implemented to avoid the above errors. There is still
a reminder about missing PM in dmesg:

Missing OMAP4 PM for this platform!

Signed-off-by: Sebastian Reichel <sre@kernel.org>
---
 arch/arm/mach-omap2/pm.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c
index 63027e60cc20..4e4313cecc26 100644
--- a/arch/arm/mach-omap2/pm.c
+++ b/arch/arm/mach-omap2/pm.c
@@ -240,6 +240,9 @@ omap_postcore_initcall(omap2_common_pm_init);
 
 int __init omap2_common_pm_late_init(void)
 {
+	if (!twl_rev())
+		return -ENODEV;
+
 	/* Init the voltage layer */
 	omap3_twl_init();
 	omap4_twl_init();
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: OMAP: PM: stop early on systems without twl Sebastian Reichel <sre@kernel.org> - 2017-06-10 00:40 +0200
  Re: [PATCH] ARM: OMAP: PM: stop early on systems without twl Tony Lindgren <tony@atomide.com> - 2017-06-12 09:50 +0200
    Re: [PATCH] ARM: OMAP: PM: stop early on systems without twl Tony Lindgren <tony@atomide.com> - 2017-06-12 12:30 +0200
      [PATCHv2] ARM: OMAP: PM: stop early on systems without twl Sebastian Reichel <sre@kernel.org> - 2017-06-13 11:50 +0200
        Re: [PATCHv2] ARM: OMAP: PM: stop early on systems without twl Tony Lindgren <tony@atomide.com> - 2017-06-14 07:50 +0200

csiph-web