Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1662795

Re: Sleeping BUG in khugepaged for i586

From David Rientjes <rientjes@google.com>
Newsgroups linux.kernel
Subject Re: Sleeping BUG in khugepaged for i586
Date 2017-06-10 00:40 +0200
Message-ID <tQAJs-7ia-21@gated-at.bofh.it> (permalink)
References (5 earlier) <tPQdA-38j-17@gated-at.bofh.it> <tQ6V4-5vT-13@gated-at.bofh.it> <tQ96y-73e-17@gated-at.bofh.it> <tQc4q-sN-21@gated-at.bofh.it> <tQcnM-z9-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Thu, 8 Jun 2017, Michal Hocko wrote:

> I would just pull the cond_resched out of __collapse_huge_page_copy
> right after pte_unmap. But I am not really sure why this cond_resched is
> really needed because the changelog of the patch which adds is is quite
> terse on details.

I'm not sure what could possibly be added to the changelog.  We have 
encountered need_resched warnings during the iteration.  We fix these 
because need_resched warnings suppress future warnings of the same type 
for issues that are more important.

I can fix the i386 issue but removing the cond_resched() entirely isn't 
really suitable.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: Sleeping BUG in khugepaged for i586 David Rientjes <rientjes@google.com> - 2017-06-07 23:00 +0200
  Re: Sleeping BUG in khugepaged for i586 Michal Hocko <mhocko@kernel.org> - 2017-06-08 16:50 +0200
    Re: Sleeping BUG in khugepaged for i586 Matthew Wilcox <willy@infradead.org> - 2017-06-08 19:10 +0200
      Re: Sleeping BUG in khugepaged for i586 Michal Hocko <mhocko@kernel.org> - 2017-06-08 22:20 +0200
        Re: Sleeping BUG in khugepaged for i586 Michal Hocko <mhocko@kernel.org> - 2017-06-08 22:40 +0200
          Re: Sleeping BUG in khugepaged for i586 Vlastimil Babka <vbabka@suse.cz> - 2017-06-09 08:50 +0200
            Re: Sleeping BUG in khugepaged for i586 Michal Hocko <mhocko@kernel.org> - 2017-06-09 09:50 +0200
            Re: Sleeping BUG in khugepaged for i586 Larry Finger <Larry.Finger@lwfinger.net> - 2017-06-09 16:30 +0200
          Re: Sleeping BUG in khugepaged for i586 David Rientjes <rientjes@google.com> - 2017-06-10 00:40 +0200
            Re: Sleeping BUG in khugepaged for i586 Michal Hocko <mhocko@kernel.org> - 2017-06-10 10:10 +0200
              Re: Sleeping BUG in khugepaged for i586 David Rientjes <rientjes@google.com> - 2017-06-12 01:30 +0200
                Re: Sleeping BUG in khugepaged for i586 Michal Hocko <mhocko@kernel.org> - 2017-06-12 08:30 +0200
                Re: Sleeping BUG in khugepaged for i586 David Rientjes <rientjes@google.com> - 2017-06-15 02:30 +0200
    Re: Sleeping BUG in khugepaged for i586 David Rientjes <rientjes@google.com> - 2017-06-15 03:20 +0200
      Re: Sleeping BUG in khugepaged for i586 Michal Hocko <mhocko@kernel.org> - 2017-06-15 10:40 +0200
  Re: Sleeping BUG in khugepaged for i586 Larry Finger <Larry.Finger@lwfinger.net> - 2017-06-08 17:30 +0200

csiph-web