Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1658921
| From | David Miller <davem@davemloft.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH][net-next] net/mlxfw: remove redundant goto on error check |
| Date | 2017-06-06 18:30 +0200 |
| Message-ID | <tPpwK-2JZ-17@gated-at.bofh.it> (permalink) |
| References | <tPkdH-7xX-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Colin King <colin.king@canonical.com>
Date: Tue, 6 Jun 2017 11:47:40 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> The check to see of err is set and the subsequent goto is extraneous
> as the next statement is where the goto is jumping to. Remove this
> redundant check and goto.
>
> Detected by CoverityScan, CID#1437734 ("Identical code for
> different branches")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH][net-next] net/mlxfw: remove redundant goto on error check Colin King <colin.king@canonical.com> - 2017-06-06 12:50 +0200 Re: [PATCH][net-next] net/mlxfw: remove redundant goto on error check David Miller <davem@davemloft.net> - 2017-06-06 18:30 +0200
csiph-web