Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1658922
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/6] perf/x86: Fix data source decoding for Skylake |
| Date | 2017-06-06 18:30 +0200 |
| Message-ID | <tPpwK-2JZ-19@gated-at.bofh.it> (permalink) |
| References | <tP8YV-nD-3@gated-at.bofh.it> <tP8YV-nD-13@gated-at.bofh.it> <tPjB0-7ik-25@gated-at.bofh.it> <tPnbA-160-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Jun 06, 2017 at 06:51:20AM -0700, Andi Kleen wrote: > > Not too happy about that.. > > > > P(LVLX, L4) | P(LVLX, REMOTE) > > > > reads like something that should be PERF_MEM_LVL_REM_CCE1 or something > > CCE1? You mean L4? #define PERF_MEM_LVL_REM_CCE1 0x400 /* Remote Cache (1 hop) */ It says 'cache' which is irrespective of level. > The two bits seem cleaner to me than enumerating all cases. But ok. I tend to agree that a separate remote,distance,type fields would have been nicer, but we seem to be stuck with this REM_* crud.. > > This new generic 'REMOTE' has too much overlap with the existing things. > > So you want a REM_NA ? Not sure... What's the point of a REM_NA vs regular NA ? "'something' happened 'not here'" vs "'something' happened". I hope Stephane has better ideas, he seems to be the one that introduced this in the first place.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/6] perf/x86: Move Nehalem PEBS code to flag Andi Kleen <andi@firstfloor.org> - 2017-06-06 00:50 +0200
[PATCH 5/6] perf, tools: Support persistent memory encoding Andi Kleen <andi@firstfloor.org> - 2017-06-06 00:50 +0200
[PATCH 2/6] perf/x86: Fix data source decoding for Skylake Andi Kleen <andi@firstfloor.org> - 2017-06-06 00:50 +0200
Re: [PATCH 2/6] perf/x86: Fix data source decoding for Skylake Peter Zijlstra <peterz@infradead.org> - 2017-06-06 12:10 +0200
Re: [PATCH 2/6] perf/x86: Fix data source decoding for Skylake Andi Kleen <andi@firstfloor.org> - 2017-06-06 16:00 +0200
Re: [PATCH 2/6] perf/x86: Fix data source decoding for Skylake Peter Zijlstra <peterz@infradead.org> - 2017-06-06 18:30 +0200
Re: [PATCH 2/6] perf/x86: Fix data source decoding for Skylake Andi Kleen <ak@linux.intel.com> - 2017-06-06 19:20 +0200
[PATCH 4/6] perf/x86: Add support for PEBS sampling persistent RAM on Skylake Andi Kleen <andi@firstfloor.org> - 2017-06-06 01:00 +0200
csiph-web