Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1658281

[PATCH v3 09/13] rhashtable: use get_random_u32 for hash_rnd

Show all headers | View raw

This is much faster and just as secure. It also has the added benefit of
probably returning better randomness at early-boot on systems with
architectural RNGs.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Cc: Thomas Graf <tgraf@suug.ch>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
---
 lib/rhashtable.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/rhashtable.c b/lib/rhashtable.c
index d9e7274a04cd..a1eb7c947f46 100644
--- a/lib/rhashtable.c
+++ b/lib/rhashtable.c
@@ -235,7 +235,7 @@ static struct bucket_table *bucket_table_alloc(struct rhashtable *ht,
 
 	INIT_LIST_HEAD(&tbl->walkers);
 
-	get_random_bytes(&tbl->hash_rnd, sizeof(tbl->hash_rnd));
+	tbl->hash_rnd = get_random_u32();
 
 	for (i = 0; i < nbuckets; i++)
 		INIT_RHT_NULLS_HEAD(tbl->buckets[i], ht, i);
-- 
2.13.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 00/13] Unseeded In-Kernel Randomness Fixes "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-06-06 03:00 +0200
  [PATCH v3 10/13] net/neighbor: use get_random_u32 for 32-bit hash random "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-06-06 03:00 +0200
  [PATCH v3 03/13] random: invalidate batched entropy after crng init "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-06-06 03:00 +0200
  [PATCH v3 09/13] rhashtable: use get_random_u32 for hash_rnd "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-06-06 03:00 +0200
  [PATCH v3 05/13] security/keys: ensure RNG is seeded before use "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-06-06 03:00 +0200
    Re: [PATCH v3 05/13] security/keys: ensure RNG is seeded before use David Howells <dhowells@redhat.com> - 2017-06-06 12:10 +0200
      Re: [PATCH v3 05/13] security/keys: ensure RNG is seeded before use "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-06-06 14:30 +0200
  [PATCH v3 01/13] random: add synchronous API for the urandom pool "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-06-06 03:00 +0200
  [PATCH v3 11/13] net/route: use get_random_int for random counter "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-06-06 03:00 +0200
  [PATCH v3 07/13] ceph: ensure RNG is seeded before using "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-06-06 03:00 +0200
  [PATCH v3 02/13] random: add get_random_{bytes,u32,u64,int,long,once}_wait family "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-06-06 03:00 +0200
    Re: [PATCH v3 02/13] random: add get_random_{bytes,u32,u64,int,long,once}_wait  family Jeffrey Walton <noloader@gmail.com> - 2017-06-06 07:20 +0200
      Re: [PATCH v3 02/13] random: add get_random_{bytes,u32,u64,int,long,once}_wait  family "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-06-06 14:30 +0200

csiph-web