Re: [PATCH v1 1/3] mfd: Add new mfd device TPS68470

From	Sakari Ailus <sakari.ailus@iki.fi>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1 1/3] mfd: Add new mfd device TPS68470
Date	2017-06-07 14:00 +0200
Message-ID	<tPHN1-68d-41@gated-at.bofh.it> (permalink)
References	<tPlt8-aF-9@gated-at.bofh.it> <tPlt8-aF-7@gated-at.bofh.it> <tPmpd-OH-47@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Andy,

On Tue, Jun 06, 2017 at 03:59:49PM +0300, Andy Shevchenko wrote:
> On Tue, Jun 6, 2017 at 2:55 PM, Rajmohan Mani <rajmohan.mani@intel.com> wrote:
> > The TPS68470 device is an advanced power management
> > unit that powers a Compact Camera Module (CCM),
> > generates clocks for image sensors, drives a dual
> > LED for Flash and incorporates two LED drivers for
> > general purpose indicators.
> >
> > This patch adds support for TPS68470 mfd device.
> 
> I dunno why you decide to send this out now, see my comments below.
> 
> > +static int tps68470_chip_init(struct tps68470 *tps)
> > +{
> > +       unsigned int version;
> > +       int ret;
> 
> > +       /* FIXME: configure these dynamically */
> 
> So, what prevents you to fix this?

Nothing I suppose. They're however not needed right now and can be
implemented later on if they're ever needed.

-- 
Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

Thread

[PATCH v1 1/3] mfd: Add new mfd device TPS68470 Rajmohan Mani <rajmohan.mani@intel.com> - 2017-06-06 14:10 +0200
  Re: [PATCH v1 1/3] mfd: Add new mfd device TPS68470 Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2017-06-06 15:00 +0200
    RE: [PATCH v1 1/3] mfd: Add new mfd device TPS68470 "Mani, Rajmohan" <rajmohan.mani@intel.com> - 2017-06-10 00:10 +0200
  Re: [PATCH v1 1/3] mfd: Add new mfd device TPS68470 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-06 15:10 +0200
    Re: [PATCH v1 1/3] mfd: Add new mfd device TPS68470 Sakari Ailus <sakari.ailus@iki.fi> - 2017-06-07 14:00 +0200
      RE: [PATCH v1 1/3] mfd: Add new mfd device TPS68470 "Mani, Rajmohan" <rajmohan.mani@intel.com> - 2017-06-10 00:20 +0200
        Re: [PATCH v1 1/3] mfd: Add new mfd device TPS68470 Lee Jones <lee.jones@linaro.org> - 2017-06-12 10:30 +0200
          RE: [PATCH v1 1/3] mfd: Add new mfd device TPS68470 "Mani, Rajmohan" <rajmohan.mani@intel.com> - 2017-06-12 11:30 +0200
    RE: [PATCH v1 1/3] mfd: Add new mfd device TPS68470 "Mani, Rajmohan" <rajmohan.mani@intel.com> - 2017-06-10 00:10 +0200

csiph-web