Re: [PATCH v1 1/3] mfd: Add new mfd device TPS68470

Path	csiph.com!goblin2!goblin1!goblin.stu.neva.ru!news.panservice.it!bofh.it!news.nic.it!robomod
From	Sakari Ailus <sakari.ailus@iki.fi>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1 1/3] mfd: Add new mfd device TPS68470
Date	Wed, 07 Jun 2017 14:00:03 +0200
Message-ID	<tPHN1-68d-41@gated-at.bofh.it> (permalink)
References	<tPlt8-aF-9@gated-at.bofh.it> <tPlt8-aF-7@gated-at.bofh.it> <tPmpd-OH-47@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	29
Organization	linux.* mail to news gateway
X-Original-Cc	Rajmohan Mani <rajmohan.mani@intel.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>, Lee Jones <lee.jones@linaro.org>, Linus Walleij <linus.walleij@linaro.org>, Alexandre Courbot <gnurou@gmail.com>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, Len Brown <lenb@kernel.org>
X-Original-Date	Wed, 7 Jun 2017 14:58:30 +0300
X-Original-Message-ID	<20170607115827.GY1019@valkosipuli.retiisi.org.uk>
X-Original-References	<1496750118-5570-1-git-send-email-rajmohan.mani@intel.com> <1496750118-5570-2-git-send-email-rajmohan.mani@intel.com> <CAHp75VfiTM2t=WxWpG4+kUfGA3DrfGfMOwxP6Cs42nGwHjAp7w@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1659723

Show key headers only | View raw

Hi Andy,

On Tue, Jun 06, 2017 at 03:59:49PM +0300, Andy Shevchenko wrote:
> On Tue, Jun 6, 2017 at 2:55 PM, Rajmohan Mani <rajmohan.mani@intel.com> wrote:
> > The TPS68470 device is an advanced power management
> > unit that powers a Compact Camera Module (CCM),
> > generates clocks for image sensors, drives a dual
> > LED for Flash and incorporates two LED drivers for
> > general purpose indicators.
> >
> > This patch adds support for TPS68470 mfd device.
> 
> I dunno why you decide to send this out now, see my comments below.
> 
> > +static int tps68470_chip_init(struct tps68470 *tps)
> > +{
> > +       unsigned int version;
> > +       int ret;
> 
> > +       /* FIXME: configure these dynamically */
> 
> So, what prevents you to fix this?

Nothing I suppose. They're however not needed right now and can be
implemented later on if they're ever needed.

-- 
Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

Thread

[PATCH v1 1/3] mfd: Add new mfd device TPS68470 Rajmohan Mani <rajmohan.mani@intel.com> - 2017-06-06 14:10 +0200
  Re: [PATCH v1 1/3] mfd: Add new mfd device TPS68470 Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2017-06-06 15:00 +0200
    RE: [PATCH v1 1/3] mfd: Add new mfd device TPS68470 "Mani, Rajmohan" <rajmohan.mani@intel.com> - 2017-06-10 00:10 +0200
  Re: [PATCH v1 1/3] mfd: Add new mfd device TPS68470 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-06 15:10 +0200
    Re: [PATCH v1 1/3] mfd: Add new mfd device TPS68470 Sakari Ailus <sakari.ailus@iki.fi> - 2017-06-07 14:00 +0200
      RE: [PATCH v1 1/3] mfd: Add new mfd device TPS68470 "Mani, Rajmohan" <rajmohan.mani@intel.com> - 2017-06-10 00:20 +0200
        Re: [PATCH v1 1/3] mfd: Add new mfd device TPS68470 Lee Jones <lee.jones@linaro.org> - 2017-06-12 10:30 +0200
          RE: [PATCH v1 1/3] mfd: Add new mfd device TPS68470 "Mani, Rajmohan" <rajmohan.mani@intel.com> - 2017-06-12 11:30 +0200
    RE: [PATCH v1 1/3] mfd: Add new mfd device TPS68470 "Mani, Rajmohan" <rajmohan.mani@intel.com> - 2017-06-10 00:10 +0200

csiph-web