Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1657280
| From | Christoph Hellwig <hch@lst.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures |
| Date | 2017-06-05 07:40 +0200 |
| Message-ID | <tOSUa-79A-19@gated-at.bofh.it> (permalink) |
| References | <tOB6V-3JJ-5@gated-at.bofh.it> <tOB6W-3JJ-15@gated-at.bofh.it> <tOFax-6tW-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sun, Jun 04, 2017 at 05:59:06PM +0300, Sagi Grimberg wrote:
>> +struct nvme_ns_identifier_hdr {
>> + __u8 nidt;
>> + __u8 nidl;
>> + __le16 reserved;
>> +};
>
> Nit: _hdr is usually associated with a message or alike.
>
> Maybe nvme_ns_id_desc is more consistent with the spec language.
The descriptor itself includes the actual value, that's why
I suggested adding the _hdr prefix. But I'm fine going either way.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-04 12:40 +0200
Re: [PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures Sagi Grimberg <sagi@grimberg.me> - 2017-06-04 16:50 +0200
Re: [PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures Sagi Grimberg <sagi@grimberg.me> - 2017-06-04 17:00 +0200
Re: [PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures Christoph Hellwig <hch@lst.de> - 2017-06-05 07:40 +0200
Re: [PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures Hannes Reinecke <hare@suse.de> - 2017-06-06 08:30 +0200
csiph-web