Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1657045 > unrolled thread
| Started by | Johannes Thumshirn <jthumshirn@suse.de> |
|---|---|
| First post | 2017-06-04 12:40 +0200 |
| Last post | 2017-06-06 08:30 +0200 |
| Articles | 5 — 4 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-04 12:40 +0200
Re: [PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures Sagi Grimberg <sagi@grimberg.me> - 2017-06-04 16:50 +0200
Re: [PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures Sagi Grimberg <sagi@grimberg.me> - 2017-06-04 17:00 +0200
Re: [PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures Christoph Hellwig <hch@lst.de> - 2017-06-05 07:40 +0200
Re: [PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures Hannes Reinecke <hare@suse.de> - 2017-06-06 08:30 +0200
| From | Johannes Thumshirn <jthumshirn@suse.de> |
|---|---|
| Date | 2017-06-04 12:40 +0200 |
| Subject | [PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures |
| Message-ID | <tOB6W-3JJ-15@gated-at.bofh.it> |
Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
---
include/linux/nvme.h | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/include/linux/nvme.h b/include/linux/nvme.h
index b625bacf37ef..afa6ef484e50 100644
--- a/include/linux/nvme.h
+++ b/include/linux/nvme.h
@@ -288,6 +288,7 @@ enum {
NVME_ID_CNS_NS = 0x00,
NVME_ID_CNS_CTRL = 0x01,
NVME_ID_CNS_NS_ACTIVE_LIST = 0x02,
+ NVME_ID_CNS_NS_DESC_LIST = 0x03,
NVME_ID_CNS_NS_PRESENT_LIST = 0x10,
NVME_ID_CNS_NS_PRESENT = 0x11,
NVME_ID_CNS_CTRL_NS_LIST = 0x12,
@@ -314,6 +315,22 @@ enum {
NVME_NS_DPS_PI_TYPE3 = 3,
};
+struct nvme_ns_identifier_hdr {
+ __u8 nidt;
+ __u8 nidl;
+ __le16 reserved;
+};
+
+#define NVME_NIDT_EUI64_LEN 8
+#define NVME_NIDT_NGUID_LEN 16
+#define NVME_NIDT_UUID_LEN 16
+
+enum {
+ NVME_NIDT_EUI64 = 0x01,
+ NVME_NIDT_NGUID = 0x02,
+ NVME_NIDT_UUID = 0x03,
+};
+
struct nvme_smart_log {
__u8 critical_warning;
__u8 temperature[2];
@@ -658,6 +675,8 @@ struct nvme_identify {
__u32 rsvd11[5];
};
+#define NVME_IDENTIFY_DATA_SIZE 4096
+
struct nvme_features {
__u8 opcode;
__u8 flags;
--
2.12.0
[toc] | [next] | [standalone]
| From | Sagi Grimberg <sagi@grimberg.me> |
|---|---|
| Date | 2017-06-04 16:50 +0200 |
| Subject | Re: [PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures |
| Message-ID | <tOF0S-6pS-5@gated-at.bofh.it> |
| In reply to | #1657045 |
Looks good Johannes, Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
[toc] | [prev] | [next] | [standalone]
| From | Sagi Grimberg <sagi@grimberg.me> |
|---|---|
| Date | 2017-06-04 17:00 +0200 |
| Subject | Re: [PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures |
| Message-ID | <tOFax-6tW-1@gated-at.bofh.it> |
| In reply to | #1657045 |
On 04/06/17 13:36, Johannes Thumshirn wrote:
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
> ---
> include/linux/nvme.h | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/include/linux/nvme.h b/include/linux/nvme.h
> index b625bacf37ef..afa6ef484e50 100644
> --- a/include/linux/nvme.h
> +++ b/include/linux/nvme.h
> @@ -288,6 +288,7 @@ enum {
> NVME_ID_CNS_NS = 0x00,
> NVME_ID_CNS_CTRL = 0x01,
> NVME_ID_CNS_NS_ACTIVE_LIST = 0x02,
> + NVME_ID_CNS_NS_DESC_LIST = 0x03,
> NVME_ID_CNS_NS_PRESENT_LIST = 0x10,
> NVME_ID_CNS_NS_PRESENT = 0x11,
> NVME_ID_CNS_CTRL_NS_LIST = 0x12,
> @@ -314,6 +315,22 @@ enum {
> NVME_NS_DPS_PI_TYPE3 = 3,
> };
>
> +struct nvme_ns_identifier_hdr {
> + __u8 nidt;
> + __u8 nidl;
> + __le16 reserved;
> +};
Nit: _hdr is usually associated with a message or alike.
Maybe nvme_ns_id_desc is more consistent with the spec language.
[toc] | [prev] | [next] | [standalone]
| From | Christoph Hellwig <hch@lst.de> |
|---|---|
| Date | 2017-06-05 07:40 +0200 |
| Subject | Re: [PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures |
| Message-ID | <tOSUa-79A-19@gated-at.bofh.it> |
| In reply to | #1657085 |
On Sun, Jun 04, 2017 at 05:59:06PM +0300, Sagi Grimberg wrote:
>> +struct nvme_ns_identifier_hdr {
>> + __u8 nidt;
>> + __u8 nidl;
>> + __le16 reserved;
>> +};
>
> Nit: _hdr is usually associated with a message or alike.
>
> Maybe nvme_ns_id_desc is more consistent with the spec language.
The descriptor itself includes the actual value, that's why
I suggested adding the _hdr prefix. But I'm fine going either way.
[toc] | [prev] | [next] | [standalone]
| From | Hannes Reinecke <hare@suse.de> |
|---|---|
| Date | 2017-06-06 08:30 +0200 |
| Subject | Re: [PATCH v4 1/8] nvme: introduce NVMe Namespace Identification Descriptor structures |
| Message-ID | <tPga5-55F-1@gated-at.bofh.it> |
| In reply to | #1657045 |
On 06/04/2017 12:36 PM, Johannes Thumshirn wrote: > Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de> > Reviewed-by: Max Gurtovoy <maxg@mellanox.com> > --- > include/linux/nvme.h | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > Reviewed-by: Hannes Reinecke <hare@suse.com> Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web