Re: [PATCH v5 12/20] ARM: dts: uniphier: Add generic compatible string for I2C EEPROM

From	Masahiro Yamada <yamada.masahiro@socionext.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 12/20] ARM: dts: uniphier: Add generic compatible string for I2C EEPROM
Date	2017-06-05 07:20 +0200
Message-ID	<tOSAN-73f-1@gated-at.bofh.it> (permalink)
References	<tKicx-3OV-3@gated-at.bofh.it> <tKicz-3OV-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi.

2017-05-23 22:34 GMT+09:00 Javier Martinez Canillas <javier@dowhile0.org>:
> The at24 driver allows to register I2C EEPROM chips using different vendor
> and devices, but the I2C subsystem does not take the vendor into account
> when matching using the I2C table since it only has device entries.
>
> But when matching using an OF table, both the vendor and device has to be
> taken into account so the driver defines only a set of compatible strings
> using the "atmel" vendor as a generic fallback for compatible I2C devices.
>
> So add this generic fallback to the device node compatible string to make
> the device to match the driver using the OF device ID table.
>
> Signed-off-by: Javier Martinez Canillas <javier@dowhile0.org>
>
> ---
>
> Changes in v5:
> - Only replace atmel variant but keep other EEPROM vendors (Geert Uytterhoeven).
>
> Changes in v4:
> - Only use the atmel manufacturer in the compatible string instead of
>   keeping the deprecated ones (Rob Herring).
>
> Changes in v3: None
> Changes in v2: None
>
>  arch/arm/boot/dts/uniphier-pro4-ace.dts    | 2 +-
>  arch/arm/boot/dts/uniphier-pro4-sanji.dts  | 2 +-
>  arch/arm/boot/dts/uniphier-pxs2-gentil.dts | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)


Why didn't you touch
arch/arm/boot/dts/uniphier-ref-daughter.dtsi ?



BTW, has the driver change merged?



-- 
Best Regards
Masahiro Yamada

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5 12/20] ARM: dts: uniphier: Add generic compatible  string for I2C EEPROM Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-05 07:20 +0200
  Re: [PATCH v5 12/20] ARM: dts: uniphier: Add generic compatible  string for I2C EEPROM Javier Martinez Canillas <javier@dowhile0.org> - 2017-06-06 11:10 +0200
    Re: [PATCH v5 12/20] ARM: dts: uniphier: Add generic compatible  string for I2C EEPROM Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-07 03:20 +0200
      Re: [PATCH v5 12/20] ARM: dts: uniphier: Add generic compatible  string for I2C EEPROM Javier Martinez Canillas <javier@dowhile0.org> - 2017-06-07 14:50 +0200

csiph-web