Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1659770

Re: [PATCH v5 12/20] ARM: dts: uniphier: Add generic compatible string for I2C EEPROM

From Javier Martinez Canillas <javier@dowhile0.org>
Newsgroups linux.kernel
Subject Re: [PATCH v5 12/20] ARM: dts: uniphier: Add generic compatible string for I2C EEPROM
Date 2017-06-07 14:50 +0200
Message-ID <tPIzn-6Gk-9@gated-at.bofh.it> (permalink)
References <tKicx-3OV-3@gated-at.bofh.it> <tKicz-3OV-39@gated-at.bofh.it> <tOSAN-73f-1@gated-at.bofh.it> <tPiEV-6IR-7@gated-at.bofh.it> <tPxNE-8aQ-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hello Masahiro,

On Wed, Jun 7, 2017 at 3:10 AM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:

[snip]

>>>
>>> Why didn't you touch
>>> arch/arm/boot/dts/uniphier-ref-daughter.dtsi ?
>>>
>>
>> Because the compatible string "microchip,24lc128" used by the I2C
>> EEPROM node on that DTS is not supported by the
>> drivers/misc/eeprom/at24.c driver (in fact the only occurrence for
>> 24lc128 I see is in that DTS).
>>
>> Maybe is a typo and it should be "microchip,24c128" instead ?
>
> I do not think so.
> I consulted a board developer.
>
> I also see 24LC128 on Microchip web site:
> http://www.microchip.com/wwwproducts/en/24LC128
>

Ah Ok, it was just a wild guess I did since the at24 driver didn't
have support for this chip variant.
My point stands though, this is an unrelated change to the goal of
this patch-series and should be fixed separately.

Best regards,
Javier

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5 12/20] ARM: dts: uniphier: Add generic compatible  string for I2C EEPROM Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-05 07:20 +0200
  Re: [PATCH v5 12/20] ARM: dts: uniphier: Add generic compatible  string for I2C EEPROM Javier Martinez Canillas <javier@dowhile0.org> - 2017-06-06 11:10 +0200
    Re: [PATCH v5 12/20] ARM: dts: uniphier: Add generic compatible  string for I2C EEPROM Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-07 03:20 +0200
      Re: [PATCH v5 12/20] ARM: dts: uniphier: Add generic compatible  string for I2C EEPROM Javier Martinez Canillas <javier@dowhile0.org> - 2017-06-07 14:50 +0200
        Re: [PATCH v5 12/20] ARM: dts: uniphier: Add generic compatible  string for I2C EEPROM Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-09 18:20 +0200

csiph-web