Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1653514
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v5 08/10] x86/hyper-v: use hypercall for remote TLB flush |
| Date | 2017-05-30 21:30 +0200 |
| Message-ID | <tMV06-2Xx-9@gated-at.bofh.it> (permalink) |
| References | <tMNFf-6JG-3@gated-at.bofh.it> <tMNFg-6JG-29@gated-at.bofh.it> <tMSEW-1o1-23@gated-at.bofh.it> <tMUQq-2TU-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, May 30, 2017 at 10:17 PM, Jork Loeser <Jork.Loeser@microsoft.com> wrote: >> > +#define HV_FLUSH_ALL_PROCESSORS 0x00000001 >> > +#define HV_FLUSH_ALL_VIRTUAL_ADDRESS_SPACES 0x00000002 >> > +#define HV_FLUSH_NON_GLOBAL_MAPPINGS_ONLY 0x00000004 >> > +#define HV_FLUSH_USE_EXTENDED_RANGE_FORMAT 0x00000008 >> >> BIT() ? > > Certainly a matter of taste. That's why ? is used, though slightly better to parse the BIT macros which is also less error prone. > Given that the Hyper-V spec lists these as hex numbers, I find the explicit numbers appropriate. Yes, but since it introduces a full set of the flags I would not see disadvantages by style. -- With Best Regards, Andy Shevchenko
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v5 08/10] x86/hyper-v: use hypercall for remote TLB flush Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-05-30 13:40 +0200
Re: [PATCH v5 08/10] x86/hyper-v: use hypercall for remote TLB flush Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-30 19:00 +0200
RE: [PATCH v5 08/10] x86/hyper-v: use hypercall for remote TLB flush Jork Loeser <Jork.Loeser@microsoft.com> - 2017-05-30 21:20 +0200
Re: [PATCH v5 08/10] x86/hyper-v: use hypercall for remote TLB flush Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-30 21:30 +0200
Re: [PATCH v5 08/10] x86/hyper-v: use hypercall for remote TLB flush Stephen Hemminger <stephen@networkplumber.org> - 2017-05-31 01:10 +0200
csiph-web