Re: [PATCH v5 08/10] x86/hyper-v: use hypercall for remote TLB flush

From	Stephen Hemminger <stephen@networkplumber.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 08/10] x86/hyper-v: use hypercall for remote TLB flush
Date	2017-05-31 01:10 +0200
Message-ID	<tMYr0-5aN-13@gated-at.bofh.it> (permalink)
References	<tMNFf-6JG-3@gated-at.bofh.it> <tMNFg-6JG-29@gated-at.bofh.it> <tMSEW-1o1-23@gated-at.bofh.it> <tMUQq-2TU-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 30 May 2017 19:17:46 +0000
Jork Loeser <Jork.Loeser@microsoft.com> wrote:

> > -----Original Message-----
> > From: Andy Shevchenko [mailto:andy.shevchenko@gmail.com]
> > Sent: Tuesday, May 30, 2017 09:53
> > To: Vitaly Kuznetsov <vkuznets@redhat.com>
> > Cc: x86@kernel.org; devel@linuxdriverproject.org; linux-
> > kernel@vger.kernel.org; KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
> > <haiyangz@microsoft.com>; Stephen Hemminger <sthemmin@microsoft.com>;
> > Thomas Gleixner <tglx@linutronix.de>; Ingo Molnar <mingo@redhat.com>; H.
> > Peter Anvin <hpa@zytor.com>; Steven Rostedt <rostedt@goodmis.org>; Jork
> > Loeser <Jork.Loeser@microsoft.com>; Simon Xiao <sixiao@microsoft.com>;
> > Andy Lutomirski <luto@kernel.org>
> > Subject: Re: [PATCH v5 08/10] x86/hyper-v: use hypercall for remote TLB flush
> > 
> > On Tue, May 30, 2017 at 2:34 PM, Vitaly Kuznetsov <vkuznets@redhat.com>
> > wrote:  
> > > +#define HV_FLUSH_ALL_PROCESSORS                        0x00000001
> > > +#define HV_FLUSH_ALL_VIRTUAL_ADDRESS_SPACES    0x00000002
> > > +#define HV_FLUSH_NON_GLOBAL_MAPPINGS_ONLY      0x00000004
> > > +#define HV_FLUSH_USE_EXTENDED_RANGE_FORMAT     0x00000008  
> > 
> > BIT() ?  
> 
> Certainly a matter of taste. Given that the Hyper-V spec lists these as hex numbers, I find the explicit numbers appropriate.
> 
> Regards,
> Jork

Keep the hex numbers, it makes more sense not to change it since rest of arch/x86/hyperv
uses hex values.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v5 08/10] x86/hyper-v: use hypercall for remote TLB flush Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-05-30 13:40 +0200
  Re: [PATCH v5 08/10] x86/hyper-v: use hypercall for remote TLB flush Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-30 19:00 +0200
    RE: [PATCH v5 08/10] x86/hyper-v: use hypercall for remote TLB flush Jork Loeser <Jork.Loeser@microsoft.com> - 2017-05-30 21:20 +0200
      Re: [PATCH v5 08/10] x86/hyper-v: use hypercall for remote TLB flush Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-30 21:30 +0200
      Re: [PATCH v5 08/10] x86/hyper-v: use hypercall for remote TLB  flush Stephen Hemminger <stephen@networkplumber.org> - 2017-05-31 01:10 +0200

csiph-web