Re: [PATCH 01/22] Revert "afs: Move UUID struct to linux/uuid.h"

From	David Howells <dhowells@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 01/22] Revert "afs: Move UUID struct to linux/uuid.h"
Date	2017-05-30 12:10 +0200
Message-ID	<tMMga-5Z0-9@gated-at.bofh.it> (permalink)
References	<tM3Cp-Hq-1@gated-at.bofh.it> <tM3Cp-Hq-3@gated-at.bofh.it> <tM3Cp-Hq-1@gated-at.bofh.it>
Organization	Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw

Christoph Hellwig <hch@lst.de> wrote:

> This reverts commit ff548773106ec7f8031bc6172e0234bd2a02c19c.
> 
> The V1 uuid intrepreatation in struct form isn't really useful to the
> rest of the kernel, and not really compatible to it either, so move it
> back to AFS instead of polluting the global uuid.h.

This isn't going to work.  You've effectively changed the types of the fields
in the UUID struct from BE to CPU-endian, but you're still calling
generate_random_uuid(), which produces a BE UUID.  You need to leave the
struct members as __beXX or stop using the core UUID routines.

Just move the struct uuid_v1 as-is to the afs headers and rename it to struct
afs_uuid.  You can then leave the (un)marshalling code alone.

David

Thread

[PATCH 01/22] Revert "afs: Move UUID struct to linux/uuid.h" Christoph Hellwig <hch@lst.de> - 2017-05-28 12:30 +0200
  Re: [PATCH 01/22] Revert "afs: Move UUID struct to linux/uuid.h" David Howells <dhowells@redhat.com> - 2017-05-30 12:10 +0200
    Re: [PATCH 01/22] Revert "afs: Move UUID struct to linux/uuid.h" Christoph Hellwig <hch@lst.de> - 2017-05-31 11:50 +0200
      Re: [PATCH 01/22] Revert "afs: Move UUID struct to linux/uuid.h" David Howells <dhowells@redhat.com> - 2017-05-31 12:40 +0200

csiph-web