Re: [PATCH 01/22] Revert "afs: Move UUID struct to linux/uuid.h"

From	Christoph Hellwig <hch@lst.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 01/22] Revert "afs: Move UUID struct to linux/uuid.h"
Date	2017-05-31 11:50 +0200
Message-ID	<tN8qm-31c-31@gated-at.bofh.it> (permalink)
References	<tM3Cp-Hq-1@gated-at.bofh.it> <tM3Cp-Hq-3@gated-at.bofh.it> <tMMga-5Z0-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, May 30, 2017 at 11:00:04AM +0100, David Howells wrote:
> This isn't going to work.  You've effectively changed the types of the fields
> in the UUID struct from BE to CPU-endian, but you're still calling
> generate_random_uuid(), which produces a BE UUID.  You need to leave the
> struct members as __beXX or stop using the core UUID routines.
> 
> Just move the struct uuid_v1 as-is to the afs headers and rename it to struct
> afs_uuid.  You can then leave the (un)marshalling code alone.

That's one option.  The other option would be to revert

"afs: Use core kernel UUID generation", as that also changed the
v1 UUID to a v4 uuid.  Does the afs protocol require a v1 uuid
or does it just use the formwat on the wire?

Thread

[PATCH 01/22] Revert "afs: Move UUID struct to linux/uuid.h" Christoph Hellwig <hch@lst.de> - 2017-05-28 12:30 +0200
  Re: [PATCH 01/22] Revert "afs: Move UUID struct to linux/uuid.h" David Howells <dhowells@redhat.com> - 2017-05-30 12:10 +0200
    Re: [PATCH 01/22] Revert "afs: Move UUID struct to linux/uuid.h" Christoph Hellwig <hch@lst.de> - 2017-05-31 11:50 +0200
      Re: [PATCH 01/22] Revert "afs: Move UUID struct to linux/uuid.h" David Howells <dhowells@redhat.com> - 2017-05-31 12:40 +0200

csiph-web