Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1651801

Re: [PATCH] ubifs: Add freeze support

From Christoph Hellwig <hch@infradead.org>
Newsgroups linux.kernel
Subject Re: [PATCH] ubifs: Add freeze support
Date 2017-05-27 10:20 +0200
Message-ID <tLF74-H2-9@gated-at.bofh.it> (permalink)
References <tLawi-6pJ-23@gated-at.bofh.it> <tLkci-4g5-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, May 26, 2017 at 11:52:42AM +0200, Richard Weinberger wrote:
> Hyunchul,
> 
> Am 26.05.2017 um 01:30 schrieb Hyunchul Lee:
> > From: Hyunchul Lee <cheol.lee@lge.com>
> > 
> > for un/freeze support, implement freeze_super and un/freeze_fs
> > of super_operations.
> > ubifs_freeze_super just calls freeze_super. because freeze_super always
> > succeeds if file system is read-only,  UBIFS errors should be checked.
> > if there are errors, UBIFS is switched to read-only mode.
> > ubifs_freeze_fs runs commit if TNC/LPT isn't clean. though all writes
> > are blocked and sync_fs is called before, if commit alreay was started
> > before writes are blocked, TNC/LPT might have dirty COW nodes.
> 
> you explain how you implement that feature, but not why.
> What is the use-case?
> I always thought this interface is only being used by LVM.

It can also be used through the FIFREEZE ioctl, but without snapshots
underneath the fs it's not all that useful.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] ubifs: Add freeze support Hyunchul Lee <hyc.lee@gmail.com> - 2017-05-26 01:40 +0200
  Re: [PATCH] ubifs: Add freeze support Richard Weinberger <richard@nod.at> - 2017-05-26 12:00 +0200
    Re: [PATCH] ubifs: Add freeze support Christoph Hellwig <hch@infradead.org> - 2017-05-27 10:20 +0200
    Re: [PATCH] ubifs: Add freeze support Hyunchul Lee <hyc.lee@gmail.com> - 2017-05-29 03:20 +0200
      Re: [PATCH] ubifs: Add freeze support Hyunchul Lee <hyc.lee@gmail.com> - 2017-05-29 06:50 +0200
        Re: [PATCH] ubifs: Add freeze support Amir Goldstein <amir73il@gmail.com> - 2017-05-29 07:50 +0200
          Re: [PATCH] ubifs: Add freeze support Richard Weinberger <richard@nod.at> - 2017-05-29 11:10 +0200
            Re: [PATCH] ubifs: Add freeze support Amir Goldstein <amir73il@gmail.com> - 2017-05-29 12:10 +0200
              Re: [PATCH] ubifs: Add freeze support Richard Weinberger <richard@nod.at> - 2017-05-29 12:20 +0200
                Re: [PATCH] ubifs: Add freeze support Amir Goldstein <amir73il@gmail.com> - 2017-05-29 13:50 +0200
  Re: [PATCH] ubifs: Add freeze support Christoph Hellwig <hch@infradead.org> - 2017-05-27 10:30 +0200
    Re: [PATCH] ubifs: Add freeze support Hyunchul Lee <hyc.lee@gmail.com> - 2017-05-29 02:50 +0200
      Re: [PATCH] ubifs: Add freeze support Hyunchul Lee <hyc.lee@gmail.com> - 2017-05-29 04:30 +0200
        Re: [PATCH] ubifs: Add freeze support Richard Weinberger <richard@nod.at> - 2017-05-29 10:50 +0200
          Re: [PATCH] ubifs: Add freeze support Hyunchul Lee <hyc.lee@gmail.com> - 2017-05-30 04:40 +0200
            Re: [PATCH] ubifs: Add freeze support Richard Weinberger <richard@nod.at> - 2017-05-30 10:00 +0200

csiph-web