Re: [PATCH] ubifs: Add freeze support

From	Hyunchul Lee <hyc.lee@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ubifs: Add freeze support
Date	2017-05-29 02:50 +0200
Message-ID	<tMh2F-MD-1@gated-at.bofh.it> (permalink)
References	<tLawi-6pJ-23@gated-at.bofh.it> <tLFgJ-Kk-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, May 27, 2017 at 01:23:38AM -0700, Christoph Hellwig wrote:
> > +static int ubifs_freeze_super(struct super_block *sb)
> > +{
> > +	struct ubifs_info *c = sb->s_fs_info;
> > +	int err;
> > +
> > +	dbg_gen("starting");
> > +	/* freeze_super always succeeds if file system is in read-only.
> > +	 * however if there are errors, UBIFS is switched to read-only mode.
> > +	 * so @ro_error should be checked.
> > +	 */
> > +	err = freeze_super(sb);
> > +	if (!err && c->ro_error) {
> > +		thaw_super(sb);
> > +		return -EIO;
> > +	}
> > +	return err;
> 
> This is just broken.  First ubifs should still properly propagate
> the errors, and second freezing/unfreezing read only file systems is
> perfectly valid, 

it is right.

> and third the freeze_super method is a special
> hack for gfs2 that should not gain additional users.

I thought that it was ok. because commit 48b6bca says "every filesystem
that implements this hooks must call the vfs freeze_super ..."

Thank you for comment.
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/

-- 

Thanks,
Hyunchul

Thread

[PATCH] ubifs: Add freeze support Hyunchul Lee <hyc.lee@gmail.com> - 2017-05-26 01:40 +0200
  Re: [PATCH] ubifs: Add freeze support Richard Weinberger <richard@nod.at> - 2017-05-26 12:00 +0200
    Re: [PATCH] ubifs: Add freeze support Christoph Hellwig <hch@infradead.org> - 2017-05-27 10:20 +0200
    Re: [PATCH] ubifs: Add freeze support Hyunchul Lee <hyc.lee@gmail.com> - 2017-05-29 03:20 +0200
      Re: [PATCH] ubifs: Add freeze support Hyunchul Lee <hyc.lee@gmail.com> - 2017-05-29 06:50 +0200
        Re: [PATCH] ubifs: Add freeze support Amir Goldstein <amir73il@gmail.com> - 2017-05-29 07:50 +0200
          Re: [PATCH] ubifs: Add freeze support Richard Weinberger <richard@nod.at> - 2017-05-29 11:10 +0200
            Re: [PATCH] ubifs: Add freeze support Amir Goldstein <amir73il@gmail.com> - 2017-05-29 12:10 +0200
              Re: [PATCH] ubifs: Add freeze support Richard Weinberger <richard@nod.at> - 2017-05-29 12:20 +0200
                Re: [PATCH] ubifs: Add freeze support Amir Goldstein <amir73il@gmail.com> - 2017-05-29 13:50 +0200
  Re: [PATCH] ubifs: Add freeze support Christoph Hellwig <hch@infradead.org> - 2017-05-27 10:30 +0200
    Re: [PATCH] ubifs: Add freeze support Hyunchul Lee <hyc.lee@gmail.com> - 2017-05-29 02:50 +0200
      Re: [PATCH] ubifs: Add freeze support Hyunchul Lee <hyc.lee@gmail.com> - 2017-05-29 04:30 +0200
        Re: [PATCH] ubifs: Add freeze support Richard Weinberger <richard@nod.at> - 2017-05-29 10:50 +0200
          Re: [PATCH] ubifs: Add freeze support Hyunchul Lee <hyc.lee@gmail.com> - 2017-05-30 04:40 +0200
            Re: [PATCH] ubifs: Add freeze support Richard Weinberger <richard@nod.at> - 2017-05-30 10:00 +0200

csiph-web