Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1650601

Re: [PATCH v2] um: add dummy ioremap and iounmap functions

From Richard Weinberger <richard@nod.at>
Newsgroups linux.kernel
Subject Re: [PATCH v2] um: add dummy ioremap and iounmap functions
Date 2017-05-25 17:50 +0200
Message-ID <tL3br-1AL-15@gated-at.bofh.it> (permalink)
References <tL3br-1AL-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Logan,

Am 25.05.2017 um 17:42 schrieb Logan Gunthorpe:
> The user mode architecture does not provide ioremap or iounmap, and
> because of this, the arch won't build when the functions are used in some
> core libraries.

Which ones are failing?
I thought we killed the problem by making CONFIG_COMPILE_TEST depend on !UML.

> I have designs to use these functions in scatterlist.c where they'd
> almost certainly never be called on the um architecture but it does need
> to compile. Thus, if the function is ever hit it returns NULL.

I was never a fan of that approach because in my opinion drivers should have
proper dependencies, including a dependency on HAS_IOMEM.

But I'll no longer block these attempts if we can get rid of tons of fallout
every kernel release.

Thanks,
//richard

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2] um: add dummy ioremap and iounmap functions Logan Gunthorpe <logang@deltatee.com> - 2017-05-25 17:50 +0200
  Re: [PATCH v2] um: add dummy ioremap and iounmap functions Richard Weinberger <richard@nod.at> - 2017-05-25 17:50 +0200
    Re: [PATCH v2] um: add dummy ioremap and iounmap functions Logan Gunthorpe <logang@deltatee.com> - 2017-05-25 18:00 +0200
      Re: [PATCH v2] um: add dummy ioremap and iounmap functions Geert Uytterhoeven <geert@linux-m68k.org> - 2017-05-27 20:10 +0200
        Re: [PATCH v2] um: add dummy ioremap and iounmap functions Logan Gunthorpe <logang@deltatee.com> - 2017-05-27 20:20 +0200

csiph-web