Groups > linux.kernel > #1651953

Re: [PATCH v2] um: add dummy ioremap and iounmap functions

From	Logan Gunthorpe <logang@deltatee.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] um: add dummy ioremap and iounmap functions
Date	2017-05-27 20:20 +0200
Message-ID	<tLOtH-7xL-5@gated-at.bofh.it> (permalink)
References	<tL3br-1AL-11@gated-at.bofh.it> <tL3br-1AL-15@gated-at.bofh.it> <tL3l8-1E0-25@gated-at.bofh.it> <tLOk1-7u5-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On 27/05/17 12:08 PM, Geert Uytterhoeven wrote:
> Still, those code patch could be protected by #ifdef CONFIG_HAS_IOMEM,
> or better, if (IS_ENABLED(CONFIG_HAS_IOMEM)).

Well I think it would have to be the former seeing the latter would
still end up trying to compile the missing function. But having ifdefs
inside code is not generally seen as good idea[1].

I'd really like to go forward with either this patch or something like
it. The other two arches that have this problem are fine with merging a
fix and adding ifdefs to work around a single arch doesn't feel right to me.

Thanks,

Logan

[1] http://yarchive.net/comp/linux/ifdefs.html

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] um: add dummy ioremap and iounmap functions Logan Gunthorpe <logang@deltatee.com> - 2017-05-25 17:50 +0200
  Re: [PATCH v2] um: add dummy ioremap and iounmap functions Richard Weinberger <richard@nod.at> - 2017-05-25 17:50 +0200
    Re: [PATCH v2] um: add dummy ioremap and iounmap functions Logan Gunthorpe <logang@deltatee.com> - 2017-05-25 18:00 +0200
      Re: [PATCH v2] um: add dummy ioremap and iounmap functions Geert Uytterhoeven <geert@linux-m68k.org> - 2017-05-27 20:10 +0200
        Re: [PATCH v2] um: add dummy ioremap and iounmap functions Logan Gunthorpe <logang@deltatee.com> - 2017-05-27 20:20 +0200

csiph-web