Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1647787

Re: [PATCH] pinctrl: core: do not explicitly free on unregister

Show all headers | View raw

On Tue, May 16, 2017 at 8:18 AM, Stefan Agner <stefan@agner.ch> wrote:

> When using the resource managed version of pinctrl, resources
> might already been freed when pinctrl_unregister is called by the
> devres framework. When calling devm_kfree on such a already freed
> resource, devres prints a warning:
>   WARNING: CPU: 0 PID: 1 at drivers/base/devres.c:891 pinmux_generic_free_functions+0xf4/0x128
>   ...
>
> Solve this by not explicitly free resources. The two affected
> functions (pinmux_generic_free_functions/pinctrl_generic_free_groups)
> are only used in pinctrl_unregister. When not using the resource
> managed version of pinctrl, the underlying device will presumably
> get freed freed soon anyway.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>

I think this is no longer needed after the fix from Tony
"pinctrl: core: Fix warning by removing bogus code"

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: core: do not explicitly free on unregister Stefan Agner <stefan@agner.ch> - 2017-05-16 08:20 +0200
  Re: [PATCH] pinctrl: core: do not explicitly free on unregister Linus Walleij <linus.walleij@linaro.org> - 2017-05-23 10:30 +0200

csiph-web