Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1647788
| From | Adam Thomson <Adam.Thomson.Opensource@diasemi.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [RESEND PATCH] ASoC: da7218: Fix incorrect usage of bitwise '&' operator for SRM check |
| Date | 2017-05-23 10:30 +0200 |
| Message-ID | <tKdmy-BV-15@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
In the SRM lock check section of code the '&' bitwise operator is used as part of checking lock status. Functionally the code works as intended, but the conditional statement is a boolean comparison so should really use '&&' logical operator instead. This commit rectifies this discrepancy. Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com> Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> --- sound/soc/codecs/da7218.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/da7218.c b/sound/soc/codecs/da7218.c index d256ebf..6e1940e 100644 --- a/sound/soc/codecs/da7218.c +++ b/sound/soc/codecs/da7218.c @@ -1457,7 +1457,7 @@ static int da7218_dai_event(struct snd_soc_dapm_widget *w, ++i; msleep(DA7218_SRM_CHECK_DELAY); } - } while ((i < DA7218_SRM_CHECK_TRIES) & (!success)); + } while ((i < DA7218_SRM_CHECK_TRIES) && (!success)); if (!success) dev_warn(codec->dev, "SRM failed to lock\n"); -- 1.9.1
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[RESEND PATCH] ASoC: da7218: Fix incorrect usage of bitwise '&' operator for SRM check Adam Thomson <Adam.Thomson.Opensource@diasemi.com> - 2017-05-23 10:30 +0200
csiph-web