Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1645589

Re: [PATCH] ib/core: not to set page dirty bit if it's already set.

Show all headers | View raw

On Thu, May 18, 2017 at 04:33:53PM -0700, Qing Huang wrote:
> This change will optimize kernel memory deregistration operations.
> __ib_umem_release() used to call set_page_dirty_lock() against every
> writable page in its memory region. Its purpose is to keep data
> synced between CPU and DMA device when swapping happens after mem
> deregistration ops. Now we choose not to set page dirty bit if it's
> already set by kernel prior to calling __ib_umem_release(). This
> reduces memory deregistration time by half or even more when we ran
> application simulation test program.

As far as I can tell this code doesn't even need set_page_dirty_lock
and could just use set_page_dirty

> 
> Signed-off-by: Qing Huang <qing.huang@oracle.com>
> ---
>  drivers/infiniband/core/umem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/core/umem.c b/drivers/infiniband/core/umem.c
> index 3dbf811..21e60b1 100644
> --- a/drivers/infiniband/core/umem.c
> +++ b/drivers/infiniband/core/umem.c
> @@ -58,7 +58,7 @@ static void __ib_umem_release(struct ib_device *dev, struct ib_umem *umem, int d
>  	for_each_sg(umem->sg_head.sgl, sg, umem->npages, i) {
>  
>  		page = sg_page(sg);
> -		if (umem->writable && dirty)
> +		if (!PageDirty(page) && umem->writable && dirty)
>  			set_page_dirty_lock(page);
>  		put_page(page);
>  	}
> -- 
> 2.9.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
---end quoted text---

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ib/core: not to set page dirty bit if it's already set. Qing Huang <qing.huang@oracle.com> - 2017-05-19 01:30 +0200
  Re: [PATCH] ib/core: not to set page dirty bit if it's already set. Christoph Hellwig <hch@infradead.org> - 2017-05-19 15:10 +0200
    Re: [PATCH] ib/core: not to set page dirty bit if it's already set. Qing Huang <qing.huang@oracle.com> - 2017-05-23 01:50 +0200
      Re: [PATCH] ib/core: not to set page dirty bit if it's already set. Christoph Hellwig <hch@infradead.org> - 2017-05-23 09:50 +0200
        Re: [PATCH] ib/core: not to set page dirty bit if it's already set. Qing Huang <qing.huang@oracle.com> - 2017-05-23 23:50 +0200

csiph-web