Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1645588
| From | Petr Mladek <pmladek@suse.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] printk: Use the main logbuf in NMI when logbuf_lock is available |
| Date | 2017-05-19 15:10 +0200 |
| Message-ID | <tIPPj-2BD-7@gated-at.bofh.it> (permalink) |
| References | <tDraV-5t6-9@gated-at.bofh.it> <tIGj0-43X-3@gated-at.bofh.it> <tIHRL-5c6-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri 2017-05-19 13:38:15, Sergey Senozhatsky wrote:
> On (05/19/17 11:58), Sergey Senozhatsky wrote:
> > > void printk_nmi_exit(void)
> > > {
> > > - this_cpu_and(printk_context, ~PRINTK_NMI_CONTEXT_MASK);
> > > + this_cpu_and(printk_context,
> > > + ~(PRINTK_NMI_CONTEXT_MASK ||
> > > + PRINTK_NMI_DEFERRED_CONTEXT_MASK));
> > > }
>
> [..]
>
> > the problem is that
> >
> > `PRINTK_NMI_CONTEXT_MASK || PRINTK_NMI_DEFERRED_CONTEXT_MASK' is 0x01
>
> d'oh... forgot to copy-paste this...
Grrr, thanks a lot for chasing this down and I am sorry for the troubles.
> ---
>
> diff --git a/kernel/printk/printk_safe.c b/kernel/printk/printk_safe.c
> index 6fec9cfb9a69..b6ff3fe4370a 100644
> --- a/kernel/printk/printk_safe.c
> +++ b/kernel/printk/printk_safe.c
> @@ -324,7 +324,7 @@ void printk_nmi_enter(void)
> void printk_nmi_exit(void)
> {
> this_cpu_and(printk_context,
> - ~(PRINTK_NMI_CONTEXT_MASK ||
> + ~(PRINTK_NMI_CONTEXT_MASK |
> PRINTK_NMI_DEFERRED_CONTEXT_MASK));
> }
I have rebased both for-4.13 and for-next branches in printk.git
with this fix. I wanted to get rid of this bug in linux-next
ASAP. Please, let me know if you would prefer to handle
this another way in the future.
Best Regards,
Petr
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v2] printk: Use the main logbuf in NMI when logbuf_lock is available Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-05-19 05:00 +0200
Re: [PATCH v2] printk: Use the main logbuf in NMI when logbuf_lock is available Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-05-19 06:40 +0200
Re: [PATCH v2] printk: Use the main logbuf in NMI when logbuf_lock is available Petr Mladek <pmladek@suse.com> - 2017-05-19 15:10 +0200
Re: [PATCH v2] printk: Use the main logbuf in NMI when logbuf_lock is available Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2017-05-20 11:10 +0200
csiph-web