Re: [PATCH] iommu/dma: fix function declaration

From	Joerg Roedel <jroedel@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] iommu/dma: fix function declaration
Date	2017-05-19 13:40 +0200
Message-ID	<tIOqe-1ui-19@gated-at.bofh.it> (permalink)
References	<tItF8-37o-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, May 18, 2017 at 03:13:57PM +0200, Arnd Bergmann wrote:
> Newly added code in the ipmmu-vmsa driver showed a small mistake
> in a header file that can't be included by itself without CONFIG_IOMMU_DMA
> enabled:
> 
> In file included from drivers/iommu/ipmmu-vmsa.c:13:0:
> include/linux/dma-iommu.h:105:94: error: 'struct device' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> 
> This adds a forward declaration for 'struct device', similar to how
> we treat the other struct types in this case.
> 
> Fixes: 3ae47292024f ("iommu/ipmmu-vmsa: Add new IOMMU_DOMAIN_DMA ops")
> Fixes: 273df9635385 ("iommu/dma: Make PCI window reservation generic")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] iommu/dma: fix function declaration Arnd Bergmann <arnd@arndb.de> - 2017-05-18 15:30 +0200
  Re: [PATCH] iommu/dma: fix function declaration Robin Murphy <robin.murphy@arm.com> - 2017-05-18 16:20 +0200
  Re: [PATCH] iommu/dma: fix function declaration Joerg Roedel <jroedel@suse.de> - 2017-05-19 13:40 +0200

csiph-web