Re: [PATCH] iommu/dma: fix function declaration

From	Robin Murphy <robin.murphy@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] iommu/dma: fix function declaration
Date	2017-05-18 16:20 +0200
Message-ID	<tIurw-3RH-9@gated-at.bofh.it> (permalink)
References	<tItF8-37o-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 18/05/17 14:13, Arnd Bergmann wrote:
> Newly added code in the ipmmu-vmsa driver showed a small mistake
> in a header file that can't be included by itself without CONFIG_IOMMU_DMA
> enabled:
> 
> In file included from drivers/iommu/ipmmu-vmsa.c:13:0:
> include/linux/dma-iommu.h:105:94: error: 'struct device' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> 
> This adds a forward declaration for 'struct device', similar to how
> we treat the other struct types in this case.

Oops, looks like this was latent from day one, thanks Arnd.

Acked-by: Robin Murphy <robin.murphy@arm.com>

> Fixes: 3ae47292024f ("iommu/ipmmu-vmsa: Add new IOMMU_DOMAIN_DMA ops")
> Fixes: 273df9635385 ("iommu/dma: Make PCI window reservation generic")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  include/linux/dma-iommu.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/dma-iommu.h b/include/linux/dma-iommu.h
> index 4eac2670bfa1..92f20832fd28 100644
> --- a/include/linux/dma-iommu.h
> +++ b/include/linux/dma-iommu.h
> @@ -78,6 +78,7 @@ void iommu_dma_get_resv_regions(struct device *dev, struct list_head *list);
>  
>  struct iommu_domain;
>  struct msi_msg;
> +struct device;
>  
>  static inline int iommu_dma_init(void)
>  {
>

Thread

[PATCH] iommu/dma: fix function declaration Arnd Bergmann <arnd@arndb.de> - 2017-05-18 15:30 +0200
  Re: [PATCH] iommu/dma: fix function declaration Robin Murphy <robin.murphy@arm.com> - 2017-05-18 16:20 +0200
  Re: [PATCH] iommu/dma: fix function declaration Joerg Roedel <jroedel@suse.de> - 2017-05-19 13:40 +0200

csiph-web