Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1642616

Re: WARNING at arch/x86/kernel/alternative.c:707 text_poke+0x25d/0x270

Show all headers | View raw

On Wed, 17 May 2017 00:15:39 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:


> > It appears that the kprobe_optimizer work thread call happened after
> > the init pages were freed, causing alternative.c to give the above
> > warning because the text that is being unoptimized happens to no longer
> > exist.  
> 
> Ah, I see. I need to check that case. Actually for the module
> init text area, kill_kprobe() correctly kicks kill_optimized_kprobe()
> so it should safe. But above case is on the init-text in kernel
> itself. I guess module_notifier may not be called for that area...

Hmm, what happens if you add a kprobe to a module, remove it, and then
remove the module. If the module is still loaded when it is removed,
wouldn't that cause the optimized probe to be delayed? Wouldn't that
open a race where the optimizer work queue can be called when no module
exists?

-- Steve

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

WARNING at arch/x86/kernel/alternative.c:707 text_poke+0x25d/0x270 Steven Rostedt <rostedt@goodmis.org> - 2017-05-16 15:50 +0200
  Re: WARNING at arch/x86/kernel/alternative.c:707  text_poke+0x25d/0x270 Masami Hiramatsu <mhiramat@kernel.org> - 2017-05-16 17:20 +0200
    Re: WARNING at arch/x86/kernel/alternative.c:707  text_poke+0x25d/0x270 Steven Rostedt <rostedt@goodmis.org> - 2017-05-16 17:40 +0200
      Re: WARNING at arch/x86/kernel/alternative.c:707  text_poke+0x25d/0x270 Masami Hiramatsu <mhiramat@kernel.org> - 2017-05-16 18:30 +0200
    Re: WARNING at arch/x86/kernel/alternative.c:707  text_poke+0x25d/0x270 Thomas Gleixner <tglx@linutronix.de> - 2017-05-16 23:50 +0200
      Re: WARNING at arch/x86/kernel/alternative.c:707  text_poke+0x25d/0x270 Masami Hiramatsu <mhiramat@kernel.org> - 2017-05-17 03:40 +0200

csiph-web