Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1640393
| From | Archit Taneja <architt@codeaurora.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 6/8] drm: Introduce drm_bridge_mode_valid() |
| Date | 2017-05-12 13:00 +0200 |
| Message-ID | <tGgsG-3ff-11@gated-at.bofh.it> (permalink) |
| References | <tFgO5-4HS-5@gated-at.bofh.it> <tFAa6-1mz-1@gated-at.bofh.it> <tFBzc-2lT-17@gated-at.bofh.it> <tGfdg-2rg-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 05/12/2017 03:08 PM, Laurent Pinchart wrote:
> Hi Daniel,
>
> On Wednesday 10 May 2017 17:14:33 Daniel Vetter wrote:
>> On Wed, May 10, 2017 at 04:41:09PM +0300, Ville Syrjälä wrote:
>>> On Tue, May 09, 2017 at 06:00:13PM +0100, Jose Abreu wrote:
>>>> Introduce a new helper function which calls mode_valid() callback
>>>> for all bridges in an encoder chain.
>>>>
>>>> Signed-off-by: Jose Abreu <joabreu@synopsys.com>
>>>> Cc: Carlos Palminha <palminha@synopsys.com>
>>>> Cc: Alexey Brodkin <abrodkin@synopsys.com>
>>>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>>>> Cc: Dave Airlie <airlied@linux.ie>
>>>> Cc: Andrzej Hajda <a.hajda@samsung.com>
>>>> Cc: Archit Taneja <architt@codeaurora.org>
>>>> ---
>>>>
>>>> drivers/gpu/drm/drm_bridge.c | 33 +++++++++++++++++++++++++++++++++
>>>> include/drm/drm_bridge.h | 2 ++
>>>> 2 files changed, 35 insertions(+)
>>>>
>>>> diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
>>>> index 86a7637..dc8cdfe 100644
>>>> --- a/drivers/gpu/drm/drm_bridge.c
>>>> +++ b/drivers/gpu/drm/drm_bridge.c
>>>> @@ -206,6 +206,39 @@ bool drm_bridge_mode_fixup(struct drm_bridge
>>>> *bridge,
>>>>
>>>> EXPORT_SYMBOL(drm_bridge_mode_fixup);
>>>>
>>>> /**
>>>>
>>>> + * drm_bridge_mode_valid - validate the mode against all bridges in the
>>>> + * encoder chain.
>>>> + * @bridge: bridge control structure
>>>> + * @mode: desired mode to be validated
>>>> + *
>>>> + * Calls &drm_bridge_funcs.mode_valid for all the bridges in the
>>>> encoder
>>>> + * chain, starting from the first bridge to the last. If at least one
>>>> bridge + * does not accept the mode the function returns the error
>>>> code.
>>>> + *
>>>> + * Note: the bridge passed should be the one closest to the encoder.
>>>> + *
>>>> + * RETURNS:
>>>> + * MODE_OK on success, drm_mode_status Enum error code on failure
>>>> + */
>>>> +enum drm_mode_status drm_bridge_mode_valid(struct drm_bridge *bridge,
>>>> + const struct drm_display_mode
> *mode)
>>>> +{
>>>> + enum drm_mode_status ret = MODE_OK;
>>>> +
>>>> + if (!bridge)
>>>> + return ret;
>>>> +
>>>> + if (bridge->funcs->mode_valid)
>>>> + ret = bridge->funcs->mode_valid(bridge, mode);
>>>> +
>>>> + if (ret != MODE_OK)
>>>> + return ret;
>>>> +
>>>> + return drm_bridge_mode_valid(bridge->next, mode);
>>>
>>> Looks like it should be pretty trivial to avoid the recursion.
>>>
>>> Am I correct in interpreting this that bridges have some kind of
>>> a hand rolled linked list implementation? Reusing the standard
>>> linked lists would allow you to use list_for_each() etc.
>>
>> Yeah it's a hand-rolled list, but current hw also has a bridge nesting
>> depth of 2, so it really doesn't matter. I guess once we have real long
>> chains of bridges we can fix this (and just using list_head sounds like a
>> great idea).
>
> Even if not really needed right now, it's a pretty easy cleanup, if Jose has
> time to handle it in v3 of this series let's not postpone it ;-)
jfyi, some of the bridge functions call the ops from the last bridge in the
chain to first, so we'd need to use list_for_each_entry_prev() (or something
like that) for them.
Archit
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/8] Introduce new mode validation callbacks Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-09 19:10 +0200
[PATCH v2 6/8] drm: Introduce drm_bridge_mode_valid() Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-09 19:10 +0200
Re: [PATCH v2 6/8] drm: Introduce drm_bridge_mode_valid() Ville Syrjälä <ville.syrjala@linux.intel.com> - 2017-05-10 15:50 +0200
Re: [PATCH v2 6/8] drm: Introduce drm_bridge_mode_valid() Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-10 16:10 +0200
Re: [PATCH v2 6/8] drm: Introduce drm_bridge_mode_valid() Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-10 16:10 +0200
Re: [PATCH v2 6/8] drm: Introduce drm_bridge_mode_valid() Daniel Vetter <daniel@ffwll.ch> - 2017-05-10 17:20 +0200
Re: [PATCH v2 6/8] drm: Introduce drm_bridge_mode_valid() Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-05-12 11:40 +0200
Re: [PATCH v2 6/8] drm: Introduce drm_bridge_mode_valid() Archit Taneja <architt@codeaurora.org> - 2017-05-12 13:00 +0200
Re: [PATCH v2 6/8] drm: Introduce drm_bridge_mode_valid() Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-05-12 13:10 +0200
Re: [PATCH v2 6/8] drm: Introduce drm_bridge_mode_valid() Archit Taneja <architt@codeaurora.org> - 2017-05-15 06:20 +0200
Re: [PATCH v2 6/8] drm: Introduce drm_bridge_mode_valid() Daniel Vetter <daniel@ffwll.ch> - 2017-05-15 08:50 +0200
[PATCH v2 4/8] drm: Add drm_connector_mode_valid() Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-09 19:10 +0200
[PATCH v2 2/8] drm: Add drm_crtc_mode_valid() Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-09 19:10 +0200
Re: [PATCH v2 2/8] drm: Add drm_crtc_mode_valid() Daniel Vetter <daniel@ffwll.ch> - 2017-05-10 10:10 +0200
Re: [PATCH v2 2/8] drm: Add drm_crtc_mode_valid() Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-10 11:00 +0200
Re: [PATCH v2 2/8] drm: Add drm_crtc_mode_valid() Daniel Vetter <daniel@ffwll.ch> - 2017-05-10 17:20 +0200
[PATCH v2 8/8] drm: arc: Use crtc->mode_valid() callback Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-09 19:10 +0200
Re: [PATCH v2 8/8] drm: arc: Use crtc->mode_valid() callback Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-05-12 12:00 +0200
Re: [PATCH v2 8/8] drm: arc: Use crtc->mode_valid() callback Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-15 03:50 +0200
[PATCH v2 5/8] drm: Use new mode_valid() helpers in connector probe helper Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-09 19:10 +0200
Re: [PATCH v2 5/8] drm: Use new mode_valid() helpers in connector probe helper Daniel Vetter <daniel@ffwll.ch> - 2017-05-10 10:10 +0200
Re: [PATCH v2 5/8] drm: Use new mode_valid() helpers in connector probe helper Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-10 11:10 +0200
Re: [PATCH v2 5/8] drm: Use new mode_valid() helpers in connector probe helper Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-05-12 11:40 +0200
Re: [PATCH v2 5/8] drm: Use new mode_valid() helpers in connector probe helper Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-12 18:10 +0200
Re: [PATCH v2 5/8] drm: Use new mode_valid() helpers in connector probe helper Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-05-14 13:10 +0200
Re: [PATCH v2 5/8] drm: Use new mode_valid() helpers in connector probe helper Daniel Vetter <daniel@ffwll.ch> - 2017-05-15 08:50 +0200
Re: [PATCH v2 5/8] drm: Use new mode_valid() helpers in connector probe helper Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-05-15 09:10 +0200
Re: [PATCH v2 5/8] drm: Use new mode_valid() helpers in connector probe helper Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-16 07:20 +0200
[PATCH v2 1/8] drm: Add crtc/encoder/bridge->mode_valid() callbacks Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-09 19:10 +0200
Re: [PATCH v2 1/8] drm: Add crtc/encoder/bridge->mode_valid() callbacks Daniel Vetter <daniel@ffwll.ch> - 2017-05-10 10:10 +0200
Re: [PATCH v2 1/8] drm: Add crtc/encoder/bridge->mode_valid() callbacks Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-10 11:10 +0200
Re: [PATCH v2 1/8] drm: Add crtc/encoder/bridge->mode_valid() callbacks Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-05-12 10:30 +0200
Re: [PATCH v2 1/8] drm: Add crtc/encoder/bridge->mode_valid() callbacks Daniel Vetter <daniel@ffwll.ch> - 2017-05-15 08:50 +0200
[PATCH v2 3/8] drm: Add drm_encoder_mode_valid() Jose Abreu <Jose.Abreu@synopsys.com> - 2017-05-09 19:10 +0200
csiph-web