Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1640352

Re: [PATCH 4/4] staging: rtl8723bs: checkpatch - resolve indentation and line width

From Greg KH <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH 4/4] staging: rtl8723bs: checkpatch - resolve indentation and line width
Date 2017-05-12 11:40 +0200
Message-ID <tGfdg-2rg-7@gated-at.bofh.it> (permalink)
References <tG7Sq-5Ik-5@gated-at.bofh.it> <tG7Sq-5Ik-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, May 11, 2017 at 06:45:24PM -0700, Matthew Giassa wrote:
> +#define	REG_INT_MIG_8723B		0x0304	/* Interrupt Migration */
> +#define	REG_BCNQ_DESA_8723B		0x0308	/* TX Beacon Descriptor Address
> +						 */
> +#define	REG_HQ_DESA_8723B		0x0310	/* TX High Queue Descriptor
> +						 * Address
> +						 */

Ick, that looks worse to me now, doesn't it to you?  Please leave the
original as-is.

Also, always test-build your patches :)

thanks,

greg k-h

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/4] staging: rtl8723bs: resolve checkpatch issues Matthew Giassa <matthew@giassa.net> - 2017-05-12 03:50 +0200
  [PATCH 4/4] staging: rtl8723bs: checkpatch - resolve indentation and line width Matthew Giassa <matthew@giassa.net> - 2017-05-12 03:50 +0200
    Re: [PATCH 4/4] staging: rtl8723bs: checkpatch - resolve indentation  and line width Greg KH <gregkh@linuxfoundation.org> - 2017-05-12 11:40 +0200
      Re: [PATCH 4/4] staging: rtl8723bs: checkpatch - resolve indentation  and line width Matthew Giassa <matthew@giassa.net> - 2017-05-12 15:00 +0200
        Re: [PATCH 4/4] staging: rtl8723bs: checkpatch - resolve indentation  and line width Matthew Giassa <matthew@giassa.net> - 2017-05-12 15:30 +0200
          Re: [PATCH 4/4] staging: rtl8723bs: checkpatch - resolve indentation  and line width Greg KH <gregkh@linuxfoundation.org> - 2017-05-12 16:00 +0200

csiph-web