Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1640433

Re: [PATCH 4/4] staging: rtl8723bs: checkpatch - resolve indentation and line width

From Matthew Giassa <matthew@giassa.net>
Newsgroups linux.kernel
Subject Re: [PATCH 4/4] staging: rtl8723bs: checkpatch - resolve indentation and line width
Date 2017-05-12 15:00 +0200
Message-ID <tGikN-4EF-13@gated-at.bofh.it> (permalink)
References <tG7Sq-5Ik-5@gated-at.bofh.it> <tG7Sq-5Ik-13@gated-at.bofh.it> <tGfdg-2rg-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

* Greg KH <gregkh@linuxfoundation.org> [2017-05-12 11:30:08 +0200]:

>On Thu, May 11, 2017 at 06:45:24PM -0700, Matthew Giassa wrote:
>> +#define	REG_INT_MIG_8723B		0x0304	/* Interrupt Migration */
>> +#define	REG_BCNQ_DESA_8723B		0x0308	/* TX Beacon Descriptor Address
>> +						 */
>> +#define	REG_HQ_DESA_8723B		0x0310	/* TX High Queue Descriptor
>> +						 * Address
>> +						 */
>
>Ick, that looks worse to me now, doesn't it to you?  Please leave the
>original as-is.

Will do.

>Also, always test-build your patches :)


Strange. That built fine on my Ubuntu x64 system:

&> make -j2 drivers/staging/rtl8723bs/

...

  CC      arch/x86/kernel/asm-offsets.s
  GEN     scripts/gdb/linux/constants.py
  CHK     include/generated/asm-offsets.h
  UPD     include/generated/asm-offsets.h
  CALL    scripts/checksyscalls.sh
  LD      drivers/staging/rtl8723bs/built-in.o

$> gcc --version
gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609

>thanks,
>
>greg k-h

Cheers!

-- 

Matthew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] staging: rtl8723bs: resolve checkpatch issues Matthew Giassa <matthew@giassa.net> - 2017-05-12 03:50 +0200
  [PATCH 4/4] staging: rtl8723bs: checkpatch - resolve indentation and line width Matthew Giassa <matthew@giassa.net> - 2017-05-12 03:50 +0200
    Re: [PATCH 4/4] staging: rtl8723bs: checkpatch - resolve indentation  and line width Greg KH <gregkh@linuxfoundation.org> - 2017-05-12 11:40 +0200
      Re: [PATCH 4/4] staging: rtl8723bs: checkpatch - resolve indentation  and line width Matthew Giassa <matthew@giassa.net> - 2017-05-12 15:00 +0200
        Re: [PATCH 4/4] staging: rtl8723bs: checkpatch - resolve indentation  and line width Matthew Giassa <matthew@giassa.net> - 2017-05-12 15:30 +0200
          Re: [PATCH 4/4] staging: rtl8723bs: checkpatch - resolve indentation  and line width Greg KH <gregkh@linuxfoundation.org> - 2017-05-12 16:00 +0200

csiph-web