Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1640185

[PATCH v2 2/3] irqchip/mbigen: Fix potential NULL dereferencing

From Hanjun Guo <guohanjun@huawei.com>
Newsgroups linux.kernel
Subject [PATCH v2 2/3] irqchip/mbigen: Fix potential NULL dereferencing
Date 2017-05-12 06:10 +0200
Message-ID <tGa3T-7oh-7@gated-at.bofh.it> (permalink)
References <tGa3T-7oh-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Hanjun Guo <hanjun.guo@linaro.org>

platform_get_resource() may return NULL, add proper
check to avoid potential NULL dereferencing.

Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
---
 drivers/irqchip/irq-mbigen.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c
index 0f5e66e..2fa1e45 100644
--- a/drivers/irqchip/irq-mbigen.c
+++ b/drivers/irqchip/irq-mbigen.c
@@ -337,6 +337,9 @@ static int mbigen_device_probe(struct platform_device *pdev)
 	mgn_chip->pdev = pdev;
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+	if (!res)
+		return -EINVAL;
+
 	mgn_chip->base = devm_ioremap(&pdev->dev, res->start,
 				      resource_size(res));
 	if (!mgn_chip->base) {
-- 
1.7.12.4

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 0/3] irqchip/mbigen: bugfixs Hanjun Guo <guohanjun@huawei.com> - 2017-05-12 06:10 +0200
  [PATCH v2 2/3] irqchip/mbigen: Fix potential NULL dereferencing Hanjun Guo <guohanjun@huawei.com> - 2017-05-12 06:10 +0200
    [tip:irq/urgent] irqchip/mbigen: Fix potential NULL dereferencing tip-bot for Hanjun Guo <tipbot@zytor.com> - 2017-05-12 10:40 +0200
  [PATCH v2 3/3] irqchip/mbigen: Fix the clear register offset Hanjun Guo <guohanjun@huawei.com> - 2017-05-12 06:10 +0200
    [tip:irq/urgent] irqchip/mbigen: Fix the clear register offset  calculation tip-bot for MaJun <tipbot@zytor.com> - 2017-05-12 10:40 +0200
  [PATCH v2 1/3] irqchip/mbigen: Fix memory mapping code Hanjun Guo <guohanjun@huawei.com> - 2017-05-12 06:10 +0200
    [tip:irq/urgent] irqchip/mbigen: Fix memory mapping code tip-bot for Hanjun Guo <tipbot@zytor.com> - 2017-05-12 10:40 +0200
  Re: [PATCH v2 0/3] irqchip/mbigen: bugfixs "majun (Euler7)" <majun258@huawei.com> - 2017-05-12 09:00 +0200
  Re: [PATCH v2 0/3] irqchip/mbigen: bugfixs Marc Zyngier <marc.zyngier@arm.com> - 2017-05-12 10:00 +0200

csiph-web