Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1638345
| From | Scott Branden <scott.branden@broadcom.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] nvmem: correct Broadcom OTP controller driver writes |
| Date | 2017-05-09 20:50 +0200 |
| Message-ID | <tFimR-5AC-5@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
From: Oza Pawandeep <oza.oza@broadcom.com>
- use data write offset to write otp data instead of read offset
- use OTP program command 0x8 to write otp with ECC rather than just
command 0xA without ECC
Change-Id: I57431f957177682f75fc05f6e372896ea3f71727
Fixes: 9d59c6e8ae27 ("nvmem: Add the Broadcom OTP controller driver")
Signed-off-by: Oza Pawandeep <oza.oza@broadcom.com>
Signed-off-by: Scott Branden <scott.branden@broadcom.com>
---
drivers/nvmem/bcm-ocotp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/nvmem/bcm-ocotp.c b/drivers/nvmem/bcm-ocotp.c
index 646cadb..3c56e3b 100644
--- a/drivers/nvmem/bcm-ocotp.c
+++ b/drivers/nvmem/bcm-ocotp.c
@@ -34,7 +34,7 @@
#define OTPC_CMD_READ 0x0
#define OTPC_CMD_OTP_PROG_ENABLE 0x2
#define OTPC_CMD_OTP_PROG_DISABLE 0x3
-#define OTPC_CMD_PROGRAM 0xA
+#define OTPC_CMD_PROGRAM 0x8
/* OTPC Status Bits */
#define OTPC_STAT_CMD_DONE BIT(1)
@@ -209,7 +209,7 @@ static int bcm_otpc_write(void *context, unsigned int offset, void *val,
set_command(priv->base, OTPC_CMD_PROGRAM);
set_cpu_address(priv->base, address++);
for (i = 0; i < priv->map->otpc_row_size; i++) {
- writel(*buf, priv->base + priv->map->data_r_offset[i]);
+ writel(*buf, priv->base + priv->map->data_w_offset[i]);
buf++;
bytes_written += sizeof(*buf);
}
--
2.5.0
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH] nvmem: correct Broadcom OTP controller driver writes Scott Branden <scott.branden@broadcom.com> - 2017-05-09 20:50 +0200
csiph-web