Re: [PATCH 11/13] PCI: Add has_mem64 for struct host_bridge

From	Christian König <deathsimple@vodafone.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 11/13] PCI: Add has_mem64 for struct host_bridge
Date	2017-05-09 13:50 +0200
Message-ID	<tFbOp-17S-5@gated-at.bofh.it> (permalink)
References	<tyyZr-1MT-3@gated-at.bofh.it> <tyyZr-1MT-5@gated-at.bofh.it> <tDy2J-1GI-3@gated-at.bofh.it> <tEMGm-1Cq-3@gated-at.bofh.it> <tEQTE-4rH-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Am 08.05.2017 um 15:25 schrieb Bjorn Helgaas:
> On Mon, May 08, 2017 at 10:54:55AM +0200, Christian König wrote:
>> Am 05.05.2017 um 01:04 schrieb Bjorn Helgaas:
>>> I *think* this will be broken by the current implementation of
>>> Christian's patch to enable a 64-bit host bridge window:
>>>
>>>    https://lkml.kernel.org/r/1493890270-1188-5-git-send-email-deathsimple@vodafone.de
>>>
>>> because pci_register_host_bridge() runs before we scan the bus, and
>>> Christian's patch adds a quirk that runs when we enumerate the AMD
>>> host bridge device.
>>>
>>> If we apply this and Christian's patch, I think we could end up with
>>> a host bridge window above 4G, but with bridge->has_mem64 not set.
>> Yes, indeed. I can adjust my patch, but I would prefer not to do so.
>>
>> I don't completely understand the background of this change, but
>> from what I know how the BIOS (at least on X86) allocates resources
>> it doesn't sounds correct to me.
>>
>> Maybe we just need a Sparc specific quirk here instead of changing
>> the common logic?
> There's nothing in Yinghai's patch that's conceptually Sparc-specific,
> so I would prefer not to artificially tie it to Sparc.

That's possible, I would need to take a closer look on them which I 
currently don't have time for.

It was more of a gut feeling considering that the current allocation 
code already looks rather complex.

> One possibility would be to compute has_mem64 when we need it instead
> of caching it.

Sounds like a good idea to me as well. I mean the code using this isn't 
time critical, isn't it?

And scanning the parent resources if a 64bit window can be found 
shouldn't be much overhead.

Christian.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 11/13] PCI: Add has_mem64 for struct host_bridge Bjorn Helgaas <helgaas@kernel.org> - 2017-05-05 01:10 +0200
  Re: [PATCH 11/13] PCI: Add has_mem64 for struct host_bridge Christian König <deathsimple@vodafone.de> - 2017-05-08 11:00 +0200
    Re: [PATCH 11/13] PCI: Add has_mem64 for struct host_bridge Bjorn Helgaas <helgaas@kernel.org> - 2017-05-08 15:30 +0200
      Re: [PATCH 11/13] PCI: Add has_mem64 for struct host_bridge Christian König <deathsimple@vodafone.de> - 2017-05-09 13:50 +0200

csiph-web